You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new noir_js is now released on NPM, which would be the go-to JavaScript package for Noir developers to make use of and is currently a wrapper of acvm_js and noirc_abi_wasm.
The current set of tests in CI, namely compile_prove_verify.test.ts, tests the use of acvm_js and noirc_abi_wasm but not the new noir_js.
This could be desirable for keeping compile_prove_verify.test.ts as a test primarily for acvm_js and noirc_abi_wasm when noir_js's feature set is expanded later on.
But as acvm_js and noirc_abi_wasm are not intended to be consumed by users individually, the value to maintain separate tests for them are hardly justifiable with the additional strain and costs.
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered:
Problem
The new noir_js is now released on NPM, which would be the go-to JavaScript package for Noir developers to make use of and is currently a wrapper of acvm_js and noirc_abi_wasm.
The current set of tests in CI, namely compile_prove_verify.test.ts, tests the use of acvm_js and noirc_abi_wasm but not the new noir_js.
Happy Case
Update compile_prove_verify.test.ts to make use of noir_js.
Replace function calls through acvm_js and noirc_abi_wasm in the test with noir_js instead.
Alternatives Considered
Leave compile_prove_verify.test.ts as is and add additional test(s) for noir_js.
This could be desirable for keeping compile_prove_verify.test.ts as a test primarily for acvm_js and noirc_abi_wasm when noir_js's feature set is expanded later on.
But as acvm_js and noirc_abi_wasm are not intended to be consumed by users individually, the value to maintain separate tests for them are hardly justifiable with the additional strain and costs.
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: