Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test noir_js in CI #2738

Closed
Tracked by #2711
Savio-Sou opened this issue Sep 18, 2023 · 0 comments · Fixed by #2744
Closed
Tracked by #2711

Test noir_js in CI #2738

Savio-Sou opened this issue Sep 18, 2023 · 0 comments · Fixed by #2744
Assignees
Labels
enhancement New feature or request

Comments

@Savio-Sou
Copy link
Collaborator

Problem

The new noir_js is now released on NPM, which would be the go-to JavaScript package for Noir developers to make use of and is currently a wrapper of acvm_js and noirc_abi_wasm.

The current set of tests in CI, namely compile_prove_verify.test.ts, tests the use of acvm_js and noirc_abi_wasm but not the new noir_js.

Happy Case

Update compile_prove_verify.test.ts to make use of noir_js.

Replace function calls through acvm_js and noirc_abi_wasm in the test with noir_js instead.

Alternatives Considered

Leave compile_prove_verify.test.ts as is and add additional test(s) for noir_js.

This could be desirable for keeping compile_prove_verify.test.ts as a test primarily for acvm_js and noirc_abi_wasm when noir_js's feature set is expanded later on.

But as acvm_js and noirc_abi_wasm are not intended to be consumed by users individually, the value to maintain separate tests for them are hardly justifiable with the additional strain and costs.

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@Savio-Sou Savio-Sou added the enhancement New feature or request label Sep 18, 2023
@Savio-Sou Savio-Sou added this to Noir Sep 18, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 18, 2023
@jonybur jonybur self-assigned this Sep 18, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants