Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a new Mem2Reg Algorithm #2406

Closed
jfecher opened this issue Aug 22, 2023 · 0 comments · Fixed by #2420
Closed

Implement a new Mem2Reg Algorithm #2406

jfecher opened this issue Aug 22, 2023 · 0 comments · Fixed by #2420
Assignees
@jfecher
Labels
enhancement New feature or request ssa

Comments

@jfecher
Copy link
Contributor

jfecher commented Aug 22, 2023

Problem

Our existing mem2reg algorithm is insufficient in that it needs to be expanded to handle aliasing and invalidation of references after they are passed to function calls. This is currently blocking a few PRs and issues, most notably #2348 which is required to fix issues such as #2382.

Happy Case

We implement a new mem2reg algorithm as detailed here: https://hackmd.io/@JakeF/S1FA9rTnh

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@jfecher jfecher added enhancement New feature or request ssa P-HIGH labels Aug 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 22, 2023
@jfecher jfecher self-assigned this Aug 22, 2023
@jfecher jfecher mentioned this issue Aug 23, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfecher jfecher

Labels
enhancement New feature or request ssa
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Implement new mem2reg pass noir-lang/noir
1 participant
@jfecher