Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: linear eval != 0 or proof computed but verification fails #1252

Closed
1 task done
kevaundray opened this issue Apr 28, 2023 · 2 comments
Closed
1 task done
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

Aztec backend has had a long standing bug in the serialization strategy that has reared it's head in two ways:

  • An error message from the proof system saying "linear eval != 0"
  • A proof being computed but then the proof verifies to be false.

The latter point is because when a proof is not satisifiable, the program will not try to compute a proof.

This bug has now been fixed as of noir-lang/acvm-backend-barretenberg@7f42535 and so this issue serves as a tracking issue to close all issues related to the bug. The fix is now contained within #1226 and will be released in 0.5.1

Proposed solution

Add all issues related to this. We should test that they now pass once that PR has been added before closing them.

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@kevaundray
Copy link
Contributor Author

@makluganteng here is another good first issue!

The referenced issues above are the ones that this issue is tracking. Now that we have merged in a fix, it would be great to check that those issues are now fixed

@kevaundray
Copy link
Contributor Author

This is no longer an issue, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant