fix: simplification of overflowing integer operations (#2153)

Fix simplification of overflowing integer operations

Author: jfecher

crates/nargo_cli/tests/execution_success/4_sub/src/main.nr

@@ -2,4 +2,8 @@
 fn main(mut x: u32, y: u32, z: u32) {
     x -= y;
     assert(x == z);
+
+    // Test constant underflow (regression for #2045)
+    let x = -1 as u4;
+    assert(x == 15);
 }

crates/noirc_evaluator/src/ssa/ir/instruction.rs

@@ -653,7 +653,7 @@ impl Binary {
 
                 let lhs = truncate(lhs.try_into_u128()?, *bit_size);
                 let rhs = truncate(rhs.try_into_u128()?, *bit_size);
-                let result = function(lhs, rhs)?;
+                let result = function(lhs, rhs);
                 truncate(result, *bit_size).into()
             }
             _ => return None,
@@ -689,18 +689,18 @@ impl BinaryOp {
         }
     }
 
-    fn get_u128_function(self) -> fn(u128, u128) -> Option<u128> {
+    fn get_u128_function(self) -> fn(u128, u128) -> u128 {
         match self {
-            BinaryOp::Add => u128::checked_add,
-            BinaryOp::Sub => u128::checked_sub,
-            BinaryOp::Mul => u128::checked_mul,
-            BinaryOp::Div => u128::checked_div,
-            BinaryOp::Mod => u128::checked_rem,
-            BinaryOp::And => |x, y| Some(x & y),
-            BinaryOp::Or => |x, y| Some(x | y),
-            BinaryOp::Xor => |x, y| Some(x ^ y),
-            BinaryOp::Eq => |x, y| Some((x == y) as u128),
-            BinaryOp::Lt => |x, y| Some((x < y) as u128),
+            BinaryOp::Add => u128::wrapping_add,
+            BinaryOp::Sub => u128::wrapping_sub,
+            BinaryOp::Mul => u128::wrapping_mul,
+            BinaryOp::Div => u128::wrapping_div,
+            BinaryOp::Mod => u128::wrapping_rem,
+            BinaryOp::And => |x, y| x & y,
+            BinaryOp::Or => |x, y| x | y,
+            BinaryOp::Xor => |x, y| x ^ y,
+            BinaryOp::Eq => |x, y| (x == y) as u128,
+            BinaryOp::Lt => |x, y| (x < y) as u128,
         }
     }
 }