Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isArray please to 2.x #318

Closed
Croydon opened this issue Jan 7, 2018 · 3 comments
Closed

Update isArray please to 2.x #318

Croydon opened this issue Jan 7, 2018 · 3 comments

Comments

@Croydon
Copy link

Croydon commented Jan 7, 2018

Please update isArray to 2.x

Dependencies checks are kinda annoying us with deprecated warnings right now 🙈

@mcollina
Copy link
Member

mcollina commented Jan 7, 2018

I would reccomend to fine-tune your checks, there is very little need to check this module.

I would see if we can update this dependency, but all the code that is there is fine.

@Croydon
Copy link
Author

Croydon commented Jan 9, 2018

I just noticed this: 66aa1ca

Depending on which Node.js versions you want to support the dependecy might not be required anymore.

@mcollina
Copy link
Member

mcollina commented Jan 9, 2018

version 2 is deprecated. The actual path is removing the dependency, and we will do this in the next major because v2 still support old versions of Node and Browsers that do not have Array.isArray().

@mcollina mcollina closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants