Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New webpage Read Streams example is confusing #6390

Closed
yoavain opened this issue Mar 2, 2024 · 3 comments
Closed

New webpage Read Streams example is confusing #6390

yoavain opened this issue Mar 2, 2024 · 3 comments
Labels
enhancement good first issue Issues for newcomers help wanted website redesign Issue/PR part of the Node.js Website Redesign

Comments

@yoavain
Copy link

yoavain commented Mar 2, 2024

Enter your suggestions in details:

Lines 3-4 of the "Read Streams" example are confusing.
I suggest extracting them into a new "Fetch" example.

image

@ovflowd
Copy link
Member

ovflowd commented Mar 2, 2024

I see! That's indeed confusing because the Read Streams shows two different examples.

Feel free to make a PR removing the first fetch part, but if possible, find a way to make the example still last 11 lines. (We're aiming for every example to be 11 lines to keep the CodeBox consistent)

@ovflowd ovflowd added enhancement good first issue Issues for newcomers website redesign Issue/PR part of the Node.js Website Redesign help wanted labels Mar 2, 2024
@bmuenzenmeyer
Copy link
Collaborator

agree on this - mentioned when first introduced too #6215 (review)

@bmuenzenmeyer
Copy link
Collaborator

closed via #6457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Issues for newcomers help wanted website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

No branches or pull requests

3 participants