Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistype in docs #496

Closed
NikIvan opened this issue Jan 30, 2016 · 4 comments
Closed

Mistype in docs #496

NikIvan opened this issue Jan 30, 2016 · 4 comments
Assignees
@JungMinu

Comments

@NikIvan
Copy link

NikIvan commented Jan 30, 2016

Docs -> Assertion Testing -> assert.notDeepEqual

Function calls in examples are assert.deepEqual(), not assert.notDeepEqual().
Results seems to be correct.
True for v4 & v5.
Thanks.
@stevemao
Copy link
Contributor

Good catch @NikIvan , PR welcome :)

@stevemao stevemao added the good first issue Issues for newcomers label Jan 30, 2016
@JungMinu JungMinu self-assigned this Jan 30, 2016
@JungMinu
Copy link
Member

I'll handle this issue :)

@JungMinu JungMinu mentioned this issue Jan 30, 2016
Closed
@lpinca
Copy link
Member

lpinca commented Feb 1, 2016

Closing, thank you.

@lpinca lpinca closed this as completed Feb 1, 2016
@stevemao stevemao added docs and removed good first issue Issues for newcomers labels Feb 1, 2016
@stevemao
Copy link
Contributor

stevemao commented Feb 3, 2016

@NikIvan for future reference, the docs are maintained @ https://github.com/nodejs/node/tree/master/doc/api, you're more than welcome to submit a pull request to fix or improve docs when you see something in need

#503 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JungMinu JungMinu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lpinca @JungMinu @stevemao @NikIvan