Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sm_code_getglobalpreloadcode_code_hook missing brackets #3070

Closed
sla100 opened this issue Apr 4, 2020 · 3 comments
Closed

sm_code_getglobalpreloadcode_code_hook missing brackets #3070

sla100 opened this issue Apr 4, 2020 · 3 comments

Comments

@sla100
Copy link

sla100 commented Apr 4, 2020

https://nodejs.org/dist/latest-v13.x/docs/api/esm.html#esm_code_getglobalpreloadcode_code_hook
current:

const require = createRequire(process.cwd + '/<preload>');

should be

const require = createRequire(process.cwd() + '/<preload>');
@nschonni
Copy link
Member

nschonni commented Apr 4, 2020

Thanks, it's confusing, but that content is actually in the https://github.com/nodejs/node repo. Do you want to open an issue or PR there? I don't have the ability to transfer you issue myself.

@sla100
Copy link
Author

sla100 commented Apr 4, 2020

nodejs/node#32657

@nschonni
Copy link
Member

nschonni commented Apr 4, 2020

Thanks @sla100 I think the docs will get updated after it lands, and the next time v13 is released

@nschonni nschonni closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants