Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on what to do with Node version in dockerization guide. #2988

Closed
mkrawczuk opened this issue Feb 26, 2020 · 4 comments
Closed

Decide on what to do with Node version in dockerization guide. #2988

mkrawczuk opened this issue Feb 26, 2020 · 4 comments

Comments

@mkrawczuk
Copy link

Currently, an old version of LTS Node is mentioned in the guide. A fix has been proposed in PR #2953, and shortly after, #2983 followed. I'm opening this issue to avoid splitting the discussion between these two PRs.

The former lets the maintainers forget about manual version bumping which may be a source of inaccuracies (as proven in PR description), but may cause problems to the users, since the version is variable and changes with new Node releases.

The latter is safer for the users, but may again cause inaccuracies, also requires manual version bump with every LTS release. It also requires to add another point to an already long list in the release process.

I would personally go with the former. Only advantage of #2983 over #2953 is that it might protect the user from some discrepancies in case of a new Node LTS release. However I believe that problems emering from such discrepancies are very improbable. Additionally, even the best guide will not prevent from misuse of software.

@richardlau
Copy link
Member

Currently, an old version of LTS Node is mentioned in the guide.

The current text uses Node.js 10 and that’s still in support until next year (April 2021). Doing nothing for now and leaving the text as-is is an option.

@mkrawczuk
Copy link
Author

The text explicitly recommends the latest LTS version (12), while the text inconsequently mentions versions 8 and 10. Please see the PRs.

@mhdawson
Copy link
Member

I'd be ok with leaving the doc as is, but then adding a line somewhere that says something like this: "we recommend the latest lts version which was 10 at the time this guide was written. Please use the latest lts version instead of 10 as shown in the examples"

@ovflowd
Copy link
Member

ovflowd commented Mar 12, 2023

Closing as it seems the parties are fine with the current content. And the guide was updated.

@ovflowd ovflowd closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants