Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lang-switcher: make it follow history #2541

Closed
XhmikosR opened this issue Sep 8, 2019 · 1 comment · Fixed by #2845
Closed

lang-switcher: make it follow history #2541

XhmikosR opened this issue Sep 8, 2019 · 1 comment · Fixed by #2845

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 8, 2019

It seems currently window.location.replace is used, which doesn't follow history.

IMO we should change this to https://developer.mozilla.org/en-US/docs/Web/API/Location/assign
@XhmikosR XhmikosR mentioned this issue Sep 25, 2019
Merged
@XhmikosR
Copy link
Contributor Author

Why was this closed? This is still unresolved without an explanation.

@XhmikosR XhmikosR reopened this Oct 12, 2019
@szhigunov szhigunov mentioned this issue Dec 19, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Sep 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lang-switcher: fix history following szhigunov/nodejs.org
2 participants
@XhmikosR @SEWeiTung