404 links and how to handle them in the future

[XhmikosR]

404 Not found	
https://github.com/nodejs/community-committee/blob/master/GOVERNANCE.md
Linked from: https://nodejs.org/en/about/community/
	
404 Not found	
https://github.com/nodejs/nodejs-ro
Linked from: https://nodejs.org/en/about/working-groups/
	
404 Not found	
http://events.linuxfoundation.org/events/node-interactive
Linked from: https://nodejs.org/en/get-involved/code-and-learn/

Scanning https://nodejs.org/docs/latest-v6.x/api/async_hooks.html
  [404] https://nodejs.org/en/404.md/

Scanning https://nodejs.org/download/chakracore-nightly/v10.5.0-nightly20180630422c132e6e/docs/api/all.html
  [404] https://nodejs.org/download/chakracore-nightly/v10.5.0-nightly20180630422c132e6e/docs/api/worker.html

Scanning https://nodejs.org/download/chakracore-nightly/v11.0.0-nightly2018061364643e6292/docs/api/all.html
  [404] https://nodejs.org/download/chakracore-nightly/v11.0.0-nightly2018061364643e6292/docs/api/worker.html

Scanning https://nodejs.org/docs/latest-v0.10.x/api/vm.html
  [404] https://nodejs.org/docs/latest-v6.x/api/async_hooks.html

For the future we could use linkinator, although we'd need to tweak it to handle the internal docs links that are missing from this repo.

[XhmikosR]

If anyone wants to help, let me know. I'm not sure how to proceed with linkinator and I'm not aware of another package that works equally good.

The problems I hit so far with linkinator:

1. I can't do linkinator build/ since the build folder doesn't have any html file
2. If I exclude any non-local links we don't get to see the full picture. But scanning the whole site takes a lot of time and currently Travis reaches the job time limit. Example: https://travis-ci.org/XhmikosR/nodejs.org/builds/580696878
3. We could try making all local links relative to server root. For example, https://nodejs.org/en/foo/ -> /en/foo/. This isn't a simple search and replace, though, because currently, we leverage Markdown's auto linking feature in many places

I'm unsure how to proceed with this at the moment. I know for sure we need such a check, even if it's just for the local files.

I'd like to hear what others think; maybe someone else has a better solution.

[Trott]

Exclude external links for now and figure out how to handle those later? That will at least prevent an issue like the slash-replace thing that broke a bunch of links on the site.

[XhmikosR]

Alright, I'll wrap my branch up and make a PR later. Note that for the canonical issue, it wouldn't have been caught since it's not an internal link.

[XhmikosR]

Although, there's still the first issue I have.

I made an upstream issue - JustinBeckwith/linkinator#82

[XhmikosR]

I've pushed the branch which checks all links here https://github.com/nodejs/nodejs.org/runs/257523435

It's too much running this on each commit, so for now, I think just doing this manually from time to time is better.

Remember there are still some false positives, but most of those are really broken links.

[XhmikosR]

I really think we should decide about these and not have a new issue/PR for each on of them :/

Anyway, in some cases, we might need to add redirects in build.

[Trott]

Are most of the ones in the GitHub Actions results in old blog posts/news items? I'd be OK with any of these to solve those:

• Archive old news/blog items at archive.org or whatever (they're probably already there) and remove them from the site. We can subsequently work with releasers to get rid of the blog. It seems like releases are the only thing that gets regularly published there, and I think trying to curate/maintain a blog is too ambitious. Our main site should be simple, easy to navigate, and manageable in size.

• Configure linkinator to ignore blog/news items.

[Trott]

https://github.com/nodejs/community-committee/blob/master/GOVERNANCE.md
should probably be https://github.com/nodejs/community-committee/tree/master/governance

https://github.com/nodejs/nodejs-ro should probably be removed along with all the other individual repos listed in that list. That is way too much information for a brief working group summary. Each of those repos is going away, slowly. Translation work happens elsewhere now. Link to CrowdIn maybe if it's not already there. But if you want to keep the change set small and hopefully uncontroversial, just remove https://github.com/nodejs/nodejs-ro and leave everything else for now.

For http://events.linuxfoundation.org/events/node-interactive, the link can be removed. The text can just be plain text with no link.

[ovflowd]

This shouldn't be relevant anymore. Inexistent links might exist, but for now there no feasible actions here, not to mention afaik we already fixed (within the website) all broken links.