From 2fe15bb306089f475d063dd59c201d33db7822ff Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 2 Jun 2016 05:48:59 +0200 Subject: [PATCH] src: remove unused internals from node.cc Remove a couple of internal methods that are neither exported in the public headers nor used internally anywhere. --- src/node.cc | 53 -------------------------------------------- src/node_internals.h | 22 ------------------ 2 files changed, 75 deletions(-) diff --git a/src/node.cc b/src/node.cc index 5fe52cafca7f04..a6f5325cb6cb58 100644 --- a/src/node.cc +++ b/src/node.cc @@ -722,47 +722,6 @@ const char *signo_string(int signo) { } -// Convenience methods - - -void ThrowError(v8::Isolate* isolate, const char* errmsg) { - Environment::GetCurrent(isolate)->ThrowError(errmsg); -} - - -void ThrowTypeError(v8::Isolate* isolate, const char* errmsg) { - Environment::GetCurrent(isolate)->ThrowTypeError(errmsg); -} - - -void ThrowRangeError(v8::Isolate* isolate, const char* errmsg) { - Environment::GetCurrent(isolate)->ThrowRangeError(errmsg); -} - - -void ThrowErrnoException(v8::Isolate* isolate, - int errorno, - const char* syscall, - const char* message, - const char* path) { - Environment::GetCurrent(isolate)->ThrowErrnoException(errorno, - syscall, - message, - path); -} - - -void ThrowUVException(v8::Isolate* isolate, - int errorno, - const char* syscall, - const char* message, - const char* path, - const char* dest) { - Environment::GetCurrent(isolate) - ->ThrowUVException(errorno, syscall, message, path, dest); -} - - Local ErrnoException(Isolate* isolate, int errorno, const char *syscall, @@ -1269,18 +1228,6 @@ Local MakeCallback(Environment* env, } -// Internal only. -Local MakeCallback(Environment* env, - Local recv, - uint32_t index, - int argc, - Local argv[]) { - Local cb_v = recv->Get(index); - CHECK(cb_v->IsFunction()); - return MakeCallback(env, recv.As(), cb_v.As(), argc, argv); -} - - Local MakeCallback(Environment* env, Local recv, Local symbol, diff --git a/src/node_internals.h b/src/node_internals.h index 695a95c5bf9fb6..0865d71a9bdb4b 100644 --- a/src/node_internals.h +++ b/src/node_internals.h @@ -55,13 +55,6 @@ v8::Local MakeCallback(Environment* env, int argc = 0, v8::Local* argv = nullptr); -// Call with valid HandleScope and while inside Context scope. -v8::Local MakeCallback(Environment* env, - v8::Local recv, - uint32_t index, - int argc = 0, - v8::Local* argv = nullptr); - // Call with valid HandleScope and while inside Context scope. v8::Local MakeCallback(Environment* env, v8::Local recv, @@ -193,21 +186,6 @@ inline MUST_USE_RESULT bool ParseArrayIndex(v8::Local arg, return true; } -void ThrowError(v8::Isolate* isolate, const char* errmsg); -void ThrowTypeError(v8::Isolate* isolate, const char* errmsg); -void ThrowRangeError(v8::Isolate* isolate, const char* errmsg); -void ThrowErrnoException(v8::Isolate* isolate, - int errorno, - const char* syscall = nullptr, - const char* message = nullptr, - const char* path = nullptr); -void ThrowUVException(v8::Isolate* isolate, - int errorno, - const char* syscall = nullptr, - const char* message = nullptr, - const char* path = nullptr, - const char* dest = nullptr); - class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator { public: inline uint32_t* zero_fill_field() { return &zero_fill_field_; }