From 48e50cbd1e3b9d01368269f85acc9f1c3727f8a6 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 14 Apr 2016 16:02:18 -0700 Subject: [PATCH 1/2] test: move debugger tests to sequential MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: https://github.com/nodejs/node/pull/6205 Fixes: https://github.com/nodejs/node/issues/6201 Reviewed-By: Jeremiah Senkpiel Reviewed-By: Johan Bergström --- test/{parallel => sequential}/test-debugger-util-regression.js | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/{parallel => sequential}/test-debugger-util-regression.js (100%) diff --git a/test/parallel/test-debugger-util-regression.js b/test/sequential/test-debugger-util-regression.js similarity index 100% rename from test/parallel/test-debugger-util-regression.js rename to test/sequential/test-debugger-util-regression.js From 639dee31bcec474e66b87256c456e88b476302a7 Mon Sep 17 00:00:00 2001 From: Santiago Gimeno Date: Fri, 15 Apr 2016 15:38:04 +0200 Subject: [PATCH 2/2] test: move the debugger tests back to parallel Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: https://github.com/nodejs/node/pull/6246 Reviewed-By: Rich Trott Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig --- test/{sequential => parallel}/test-debugger-util-regression.js | 1 + 1 file changed, 1 insertion(+) rename test/{sequential => parallel}/test-debugger-util-regression.js (98%) diff --git a/test/sequential/test-debugger-util-regression.js b/test/parallel/test-debugger-util-regression.js similarity index 98% rename from test/sequential/test-debugger-util-regression.js rename to test/parallel/test-debugger-util-regression.js index cf32ec3fa668e9..a2461a480c9466 100644 --- a/test/sequential/test-debugger-util-regression.js +++ b/test/parallel/test-debugger-util-regression.js @@ -12,6 +12,7 @@ const fixture = path.join( const args = [ 'debug', + `--port=${common.PORT}`, fixture ];