From 8a865dbee228f91e923c5d154ec22dba3302b5e8 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Sat, 25 Jan 2025 11:18:45 +0100 Subject: [PATCH] test: reduce number of written chunks Reduce chances of write errors while the request is sent. Refs: https://github.com/nodejs/node/pull/56756 --- ...t-http-server-headers-timeout-delayed-headers.js | 10 ++++++---- ...tp-server-headers-timeout-interrupted-headers.js | 8 +++++--- ...test-http-server-request-timeout-delayed-body.js | 11 ++++++----- ...t-http-server-request-timeout-delayed-headers.js | 10 ++++++---- ...-http-server-request-timeout-interrupted-body.js | 13 +++++++------ ...tp-server-request-timeout-interrupted-headers.js | 8 +++++--- 6 files changed, 35 insertions(+), 25 deletions(-) diff --git a/test/parallel/test-http-server-headers-timeout-delayed-headers.js b/test/parallel/test-http-server-headers-timeout-delayed-headers.js index af4a5df4b7f530..84ae30016f1656 100644 --- a/test/parallel/test-http-server-headers-timeout-delayed-headers.js +++ b/test/parallel/test-http-server-headers-timeout-delayed-headers.js @@ -53,10 +53,12 @@ server.listen(0, common.mustCall(() => { sendDelayedRequestHeaders = common.mustCall(() => { setTimeout(() => { - client.write('POST / HTTP/1.1\r\n'); - client.write('Content-Length: 20\r\n'); - client.write('Connection: close\r\n\r\n'); - client.write('12345678901234567890\r\n\r\n'); + client.write( + 'POST / HTTP/1.1\r\n' + + 'Content-Length: 20\r\n' + + 'Connection: close\r\n\r\n' + + '12345678901234567890\r\n\r\n' + ); }, common.platformTimeout(headersTimeout * 2)).unref(); }); })); diff --git a/test/parallel/test-http-server-headers-timeout-interrupted-headers.js b/test/parallel/test-http-server-headers-timeout-interrupted-headers.js index 9d25940ec65cd1..8295c2029e4326 100644 --- a/test/parallel/test-http-server-headers-timeout-interrupted-headers.js +++ b/test/parallel/test-http-server-headers-timeout-interrupted-headers.js @@ -50,9 +50,11 @@ server.listen(0, common.mustCall(() => { client.on('error', errOrEnd); client.resume(); - client.write('GET / HTTP/1.1\r\n'); - client.write('Connection: close\r\n'); - client.write('X-CRASH: '); + client.write( + 'GET / HTTP/1.1\r\n' + + 'Connection: close\r\n' + + 'X-CRASH: ' + ); sendDelayedRequestHeaders = common.mustCall(() => { setTimeout(() => { diff --git a/test/parallel/test-http-server-request-timeout-delayed-body.js b/test/parallel/test-http-server-request-timeout-delayed-body.js index fdfbbb2f4cb4e8..fe4ec1d8a71072 100644 --- a/test/parallel/test-http-server-request-timeout-delayed-body.js +++ b/test/parallel/test-http-server-request-timeout-delayed-body.js @@ -46,11 +46,12 @@ server.listen(0, common.mustCall(() => { })); client.resume(); - client.write('POST / HTTP/1.1\r\n'); - client.write('Host: example.com\r\n'); - client.write('Content-Length: 20\r\n'); - client.write('Connection: close\r\n'); - client.write('\r\n'); + client.write( + 'POST / HTTP/1.1\r\n' + + 'Host: example.com\r\n' + + 'Content-Length: 20\r\n' + + 'Connection: close\r\n\r\n' + ); sendDelayedRequestBody = common.mustCall(() => { setTimeout(() => { diff --git a/test/parallel/test-http-server-request-timeout-delayed-headers.js b/test/parallel/test-http-server-request-timeout-delayed-headers.js index 304a78b96a77d3..b5681aa3af1cdd 100644 --- a/test/parallel/test-http-server-request-timeout-delayed-headers.js +++ b/test/parallel/test-http-server-request-timeout-delayed-headers.js @@ -48,10 +48,12 @@ server.listen(0, common.mustCall(() => { sendDelayedRequestHeaders = common.mustCall(() => { setTimeout(() => { - client.write('POST / HTTP/1.1\r\n'); - client.write('Content-Length: 20\r\n'); - client.write('Connection: close\r\n\r\n'); - client.write('12345678901234567890\r\n\r\n'); + client.write( + 'POST / HTTP/1.1\r\n' + + 'Content-Length: 20\r\n' + + 'Connection: close\r\n\r\n' + + '12345678901234567890\r\n\r\n' + ); }, common.platformTimeout(requestTimeout * 2)).unref(); }); })); diff --git a/test/parallel/test-http-server-request-timeout-interrupted-body.js b/test/parallel/test-http-server-request-timeout-interrupted-body.js index 82c2f3171736a6..093f27e8f19f8d 100644 --- a/test/parallel/test-http-server-request-timeout-interrupted-body.js +++ b/test/parallel/test-http-server-request-timeout-interrupted-body.js @@ -57,12 +57,13 @@ server.listen(0, common.mustCall(() => { client.on('end', errOrEnd); client.resume(); - client.write('POST / HTTP/1.1\r\n'); - client.write('Host: example.com\r\n'); - client.write('Content-Length: 20\r\n'); - client.write('Connection: close\r\n'); - client.write('\r\n'); - client.write('1234567890'); + client.write( + 'POST / HTTP/1.1\r\n' + + 'Host: example.com\r\n' + + 'Content-Length: 20\r\n' + + 'Connection: close\r\n\r\n' + + '1234567890' + ); sendDelayedRequestBody = common.mustCall(() => { setTimeout(() => { diff --git a/test/parallel/test-http-server-request-timeout-interrupted-headers.js b/test/parallel/test-http-server-request-timeout-interrupted-headers.js index eb9914dad1f56a..1e46360fcabcde 100644 --- a/test/parallel/test-http-server-request-timeout-interrupted-headers.js +++ b/test/parallel/test-http-server-request-timeout-interrupted-headers.js @@ -45,9 +45,11 @@ server.listen(0, common.mustCall(() => { client.on('error', errOrEnd); client.resume(); - client.write('GET / HTTP/1.1\r\n'); - client.write('Connection: close\r\n'); - client.write('X-CRASH: '); + client.write( + 'GET / HTTP/1.1\r\n' + + 'Connection: close\r\n' + + 'X-CRASH: ' + ); sendDelayedRequestHeaders = common.mustCall(() => { setTimeout(() => {