Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move one or more collaborators to emeritus #52457

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-collaborators.yml.

@nodejs/tsc Please follow up with the offboarding tasks.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Apr 10, 2024
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MoLow
Copy link
Member

MoLow commented Apr 11, 2024

CC @antsmartian @AshCripps @bmeck @ChALkeR @danbev @devsnek @mscdex @rickyes @ryzokuken @shisama @vdeturckheim
See nodejs/TSC#1524 and #52425

@devsnek
Copy link
Member

devsnek commented Apr 11, 2024

I'm actively an openjs foundation delegate, idk if that has any bearing on node collaborator freshness or not, but if it does I should not be moved here.

@vdeturckheim
Copy link
Member

Ack (and make sense) - @mhdawson quick question, I don't need to be a core collaborator to stay on the security triage team?

Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@shisama
Copy link
Contributor

shisama commented Apr 11, 2024

@MoLow Thanks for the notification. I have been busy with the other things. However, I want to be back to work on this project in the future. Can I be back to the collaborator in the future?

@MoLow
Copy link
Member

MoLow commented Apr 11, 2024

I have been busy with the other things. However, I want to be back to work on this project in the future.

Looking forward to seeing you again. being a collaborator isn't a requirement for most activity in node

Can I be back to the collaborator in the future?

Sure. the requirements are the same as any other collaborator nomination

@benjamingr
Copy link
Member

@MoLow actually there is a simpler process, if a collaborator wishes to return to active status they email the TSC and ask, if they have a good reason (and ideally recent'ish activity) they get reinstated.

From the governance:

Emeriti may request that the TSC restore them to active status.

Notably, the TSC can object to reinstating a collaborator that has been made emeritus but they don't have to go through the process of private+public nominations and collaborators can't object.

@mhdawson
Copy link
Member

Ack (and make sense) - @mhdawson quick question, I don't need to be a core collaborator to stay on the security triage team?

I don't think there is any requirement for that, but if it turns out there is, I suspect the suggestion would be that we change that.

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChALkeR is still listed as TSC. I suggest we first land #52476, so the tooling can catch this kind of discrepancy.

@shisama
Copy link
Contributor

shisama commented Apr 13, 2024

@MoLow @benjamingr
Thank you for your answer. I hope to collaborate with you again in the future 👋

@MoLow MoLow requested a review from aduh95 April 13, 2024 21:03
@MoLow
Copy link
Member

MoLow commented Apr 13, 2024

@aduh95 can you please approve? this also seems to need a rebase

@aduh95 aduh95 force-pushed the actions/inactive-collaborators branch from aace27c to 380817a Compare April 13, 2024 22:37
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2024
@anonrig
Copy link
Member

anonrig commented Apr 13, 2024

@nodejs/tsc did anybody completed the off boarding tasks?

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2024
aduh95 added a commit to nodejs/create-node-meeting-artifacts that referenced this pull request Apr 14, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2024
@nodejs-github-bot nodejs-github-bot merged commit 39996ac into main Apr 14, 2024
18 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/inactive-collaborators branch April 14, 2024 09:02
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 39996ac

anonrig pushed a commit to nodejs/create-node-meeting-artifacts that referenced this pull request Apr 14, 2024
@rickyes
Copy link
Contributor

rickyes commented Apr 24, 2024

Thanks for the reminder, I've been busy with a new job lately and look forward to working together again later!

aduh95 pushed a commit that referenced this pull request Apr 29, 2024
PR-URL: #52457
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ash Cripps <email@ashleycripps.co.uk>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #52457
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ash Cripps <email@ashleycripps.co.uk>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
PR-URL: #52457
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ash Cripps <email@ashleycripps.co.uk>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.