test: reduce flakiness of test-runner-output.mjs #52146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is similar to nodejs#51952. When the system is under load it is possible for these timeout tests to become flaky. We work around that by using a much longer setTimeout() in the test so that it is not racing against the test's timeout. But, we have to unref() such a large timeout. And, because test timeouts do not currently keep the event loop alive, we use a different setTimeout() for that purpose. Fixes: nodejs#52139 Refs: nodejs#52140
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Mar 18, 2024
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
MoLow
approved these changes
Mar 19, 2024
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 978d5a2 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
This commit is similar to nodejs#51952. When the system is under load it is possible for these timeout tests to become flaky. We work around that by using a much longer setTimeout() in the test so that it is not racing against the test's timeout. But, we have to unref() such a large timeout. And, because test timeouts do not currently keep the event loop alive, we use a different setTimeout() for that purpose. Fixes: nodejs#52139 Refs: nodejs#52140 PR-URL: nodejs#52146 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
This commit is similar to #51952. When the system is under load it is possible for these timeout tests to become flaky. We work around that by using a much longer setTimeout() in the test so that it is not racing against the test's timeout. But, we have to unref() such a large timeout. And, because test timeouts do not currently keep the event loop alive, we use a different setTimeout() for that purpose. Fixes: #52139 Refs: #52140 PR-URL: #52146 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
This commit is similar to #51952. When the system is under load it is possible for these timeout tests to become flaky. We work around that by using a much longer setTimeout() in the test so that it is not racing against the test's timeout. But, we have to unref() such a large timeout. And, because test timeouts do not currently keep the event loop alive, we use a different setTimeout() for that purpose. Fixes: #52139 Refs: #52140 PR-URL: #52146 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is similar to #51952. When the system is under load it is possible for these timeout tests to become flaky. We work around that by using a much longer
setTimeout()in the test so that it is not racing against the test's timeout. But, we have tounref()such a large timeout. And, because test timeouts do not currently keep the event loop alive, we use a differentsetTimeout()for that purpose.Fixes: #52139
Refs: #52140