From 33a63261c368c4cd6be47ee22153a559af92ea01 Mon Sep 17 00:00:00 2001 From: bcoe Date: Fri, 9 Oct 2020 14:56:56 -0700 Subject: [PATCH 1/5] doc: document rmdir/recursive deprecation Document deprecation of rmdir/recursive permissive functionality --- doc/api/deprecations.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index bc693fe561ce0b..2b277f88fe9636 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2655,6 +2655,20 @@ Type: Documentation-only The [`crypto.Certificate()` constructor][] is deprecated. Use [static methods of `crypto.Certificate()`][] instead. +### DEP0XXX: `fs.rmdir(path, { recursive: true })` + + +Type: Documentation-only + +`fs.rmdir(path, { recursive: true })` will throw on nonexistent paths, or when +given a file as a target. Use `fs.rm(path, { recursive: true, force: true })` +instead. + [Legacy URL API]: url.md#url_legacy_url_api [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3 From 84d4d6490f59e4186ee644bc74872e7974b9be11 Mon Sep 17 00:00:00 2001 From: "Benjamin E. Coe" Date: Fri, 9 Oct 2020 18:10:44 -0700 Subject: [PATCH 2/5] Update doc/api/deprecations.md Co-authored-by: Anna Henningsen --- doc/api/deprecations.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 2b277f88fe9636..e310f291e1e7f3 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2660,7 +2660,7 @@ The [`crypto.Certificate()` constructor][] is deprecated. Use changes: - version: REPLACME pr-url: https://github.com/nodejs/node/pull/35562 - description: Runtime deprecation. + description: Documentation-only deprecation. --> Type: Documentation-only From a0372b21749a130b4a49292023f9befec1c99d55 Mon Sep 17 00:00:00 2001 From: bcoe Date: Fri, 9 Oct 2020 18:16:49 -0700 Subject: [PATCH 3/5] chore: address code review --- doc/api/deprecations.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index e310f291e1e7f3..ede10b1918db4e 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2665,9 +2665,9 @@ changes: Type: Documentation-only -`fs.rmdir(path, { recursive: true })` will throw on nonexistent paths, or when -given a file as a target. Use `fs.rm(path, { recursive: true, force: true })` -instead. +In future versions of Node.js, `fs.rmdir(path, { recursive: true })` will throw +on nonexistent paths, or when given a file as a target. +Use `fs.rm(path, { recursive: true, force: true })` instead. [Legacy URL API]: url.md#url_legacy_url_api [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf From 485c01a66ba3d7e1c9c37ac7f654c73bbcc15d12 Mon Sep 17 00:00:00 2001 From: bcoe Date: Sun, 11 Oct 2020 12:11:25 -0700 Subject: [PATCH 4/5] docs: link to PR where we introduced deprecation language --- doc/api/deprecations.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index ede10b1918db4e..75d6725e887961 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2659,7 +2659,7 @@ The [`crypto.Certificate()` constructor][] is deprecated. Use From fda087715fb5867e9a923179041970480c2c9b0c Mon Sep 17 00:00:00 2001 From: bcoe Date: Sun, 11 Oct 2020 12:42:27 -0700 Subject: [PATCH 5/5] docs: should be PR itself --- doc/api/deprecations.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 75d6725e887961..0b1b8c5fa23484 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2659,7 +2659,7 @@ The [`crypto.Certificate()` constructor][] is deprecated. Use