diff --git a/lib/_http_server.js b/lib/_http_server.js index 2c48ab9191846b..862b7c970bda8e 100644 --- a/lib/_http_server.js +++ b/lib/_http_server.js @@ -618,8 +618,6 @@ function resOnFinish(req, res, socket, state, server) { assert(state.incoming.length === 0 || state.incoming[0] === req); state.incoming.shift(); - // Reset the .incoming property so that the request object can be gc'ed. - if (socket.parser) socket.parser.incoming = null; // If the user never called req.read(), and didn't pipe() or // .resume() or .on('data'), then we call req._dump() so that the diff --git a/test/parallel/test-http-server-keepalive-end.js b/test/parallel/test-http-server-keepalive-end.js new file mode 100644 index 00000000000000..1e3a44d368a020 --- /dev/null +++ b/test/parallel/test-http-server-keepalive-end.js @@ -0,0 +1,29 @@ +'use strict'; + +const common = require('../common'); +const { createServer } = require('http'); +const { connect } = require('net'); + +const server = createServer(common.mustCall((req, res) => { + req.on('end', common.mustCall()); + res.end('hello world'); +})); + +server.unref(); + +server.listen(0, common.mustCall(() => { + + const client = connect(server.address().port); + + const req = [ + 'POST / HTTP/1.1', + `Host: localhost:${server.address().port}`, + 'Connection: keep-alive', + 'Content-Length: 11', + '', + 'hello world', + '' + ].join('\r\n'); + + client.end(req); +}));