From 8391ff588c0b05064225b20e9f45081276d122dc Mon Sep 17 00:00:00 2001 From: Aditya Pratap Singh Date: Sat, 4 May 2019 13:45:48 +0200 Subject: [PATCH 1/5] doc: add example to test doc for clarity Update the documentation for test execution for tests in a single file --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index a077eb933b1df4..4081a24d910527 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -295,7 +295,7 @@ If you want to run the linter without running tests, use `make lint`/`vcbuild lint`. It will run both JavaScript linting and C++ linting. -If you are updating tests and just want to run a single test to check it: +If you are updating tests and just want to run a single test(e.g. `parallel/test-stream2-transform`) to check it: ```text $ python tools/test.py -J --mode=release parallel/test-stream2-transform From d40a6600a805ddbf480126c690aea8478324d8e0 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 4 May 2019 14:35:20 +0200 Subject: [PATCH 2/5] Update BUILDING.md Co-Authored-By: addityasingh --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 4081a24d910527..ef92dc93c9ae5e 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -295,7 +295,7 @@ If you want to run the linter without running tests, use `make lint`/`vcbuild lint`. It will run both JavaScript linting and C++ linting. -If you are updating tests and just want to run a single test(e.g. `parallel/test-stream2-transform`) to check it: +If you are updating tests and just want to run a single test (e.g. `test/parallel/test-stream2-transform.js`) to check it: ```text $ python tools/test.py -J --mode=release parallel/test-stream2-transform From e96a4aa26dabe01327afdb00e06248d417f708f7 Mon Sep 17 00:00:00 2001 From: Aditya Pratap Singh Date: Sat, 4 May 2019 16:30:48 +0200 Subject: [PATCH 3/5] doc: Fix lint by breaking line --- BUILDING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index ef92dc93c9ae5e..4e2fc7829f556a 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -295,7 +295,8 @@ If you want to run the linter without running tests, use `make lint`/`vcbuild lint`. It will run both JavaScript linting and C++ linting. -If you are updating tests and just want to run a single test (e.g. `test/parallel/test-stream2-transform.js`) to check it: +If you are updating tests and just want to run a single test to check it +e.g. To just run the tests in `test/parallel/test-stream2-transform.js`: ```text $ python tools/test.py -J --mode=release parallel/test-stream2-transform From 0b105ace21a7f56f6ec8dd83a247cb1cf0e46509 Mon Sep 17 00:00:00 2001 From: Aditya Pratap Singh Date: Sun, 5 May 2019 19:35:11 +0200 Subject: [PATCH 4/5] doc: Fix review comments --- BUILDING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 4e2fc7829f556a..2d965eb6b87c90 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -295,11 +295,11 @@ If you want to run the linter without running tests, use `make lint`/`vcbuild lint`. It will run both JavaScript linting and C++ linting. -If you are updating tests and just want to run a single test to check it -e.g. To just run the tests in `test/parallel/test-stream2-transform.js`: +If you are updating tests and just want to run tests in a single test file +(e.g. `test/parallel/test-stream2-transform.js`) to check it: ```text -$ python tools/test.py -J --mode=release parallel/test-stream2-transform +$ python tools/test.py parallel/test-stream2-transform.js ``` You can execute the entire suite of tests for a given subsystem From 89ce7b296aab2ec78f39f726d8a34245abdfd81b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 6 May 2019 09:49:04 +0200 Subject: [PATCH 5/5] Apply suggestions from code review Co-Authored-By: addityasingh --- BUILDING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 2d965eb6b87c90..8f35fa20cde45b 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -295,8 +295,8 @@ If you want to run the linter without running tests, use `make lint`/`vcbuild lint`. It will run both JavaScript linting and C++ linting. -If you are updating tests and just want to run tests in a single test file -(e.g. `test/parallel/test-stream2-transform.js`) to check it: +If you are updating tests and want to run tests in a single test file +(e.g. `test/parallel/test-stream2-transform.js`): ```text $ python tools/test.py parallel/test-stream2-transform.js