From aeb44816afc94ea87bc4d1ff1bb214653ea98fe5 Mon Sep 17 00:00:00 2001 From: cclauss Date: Fri, 7 Dec 2018 07:16:47 +0100 Subject: [PATCH 1/2] tools: do not lint tools/inspector_protocol --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6dfc1de6af5833..a58ca82011c668 100644 --- a/Makefile +++ b/Makefile @@ -1286,7 +1286,7 @@ ifneq ("","$(wildcard tools/pip/site-packages)") lint-py: PYTHONPATH=tools/pip $(PYTHON) -m flake8 . \ --count --show-source --statistics --select=E901,E999,F821,F822,F823 \ - --exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/jinja2,tools/pip + --exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/pip else lint-py: @echo "Python linting with flake8 is not avalible" From c0d18f79b7a51ff59aacaf7d608906c20727bff9 Mon Sep 17 00:00:00 2001 From: cclauss Date: Fri, 7 Dec 2018 11:22:47 +0100 Subject: [PATCH 2/2] Add tools/markupsafe to the exclude list $ __make lint-py__ ``` ./tools/markupsafe/_compat.py:21:17: F821 undefined name 'unicode' text_type = unicode ^ ./tools/markupsafe/_compat.py:22:26: F821 undefined name 'unicode' string_types = (str, unicode) ^ ./tools/markupsafe/_compat.py:24:23: F821 undefined name 'long' int_types = (int, long) ^ ``` --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a58ca82011c668..ce4cf461416224 100644 --- a/Makefile +++ b/Makefile @@ -1286,7 +1286,7 @@ ifneq ("","$(wildcard tools/pip/site-packages)") lint-py: PYTHONPATH=tools/pip $(PYTHON) -m flake8 . \ --count --show-source --statistics --select=E901,E999,F821,F822,F823 \ - --exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/pip + --exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip else lint-py: @echo "Python linting with flake8 is not avalible"