From 07b1e640e3dba2efc9844a0dd80525a1d65719da Mon Sep 17 00:00:00 2001 From: Prabu Subra Date: Sat, 17 Nov 2018 15:50:43 +0530 Subject: [PATCH 1/6] running test --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 533b36bf8dbd58..f3376197eab81a 100644 --- a/README.md +++ b/README.md @@ -591,3 +591,4 @@ Other keys used to sign some previous releases: [Working Groups]: https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md [Strategic Initiatives]: https://github.com/nodejs/TSC/blob/master/Strategic-Initiatives.md [#node.js channel on chat.freenode.net]: https://webchat.freenode.net?channels=node.js&uio=d4 + From b7dc9171319deaddbed7158fc7d0180df3e56be7 Mon Sep 17 00:00:00 2001 From: Prabu Date: Sat, 17 Nov 2018 17:55:27 +0530 Subject: [PATCH 2/6] replacing anonymous closure function with arrow function --- test/parallel/test-http-server-stale-close.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-http-server-stale-close.js b/test/parallel/test-http-server-stale-close.js index b72c2b55a02f25..9502d570942e41 100644 --- a/test/parallel/test-http-server-stale-close.js +++ b/test/parallel/test-http-server-stale-close.js @@ -34,10 +34,10 @@ if (process.env.NODE_TEST_FORK_PORT) { req.write('BAM'); req.end(); } else { - const server = http.createServer(function(req, res) { + const server = http.createServer((req, res) => { res.writeHead(200, { 'Content-Length': '42' }); req.pipe(res); - req.on('close', function() { + req.on('close', () => { server.close(); res.end(); }); From 1ff4174e26f6889cbc61e15c2c94512f3703e52b Mon Sep 17 00:00:00 2001 From: Prabu Date: Sat, 17 Nov 2018 18:16:55 +0530 Subject: [PATCH 3/6] replace anonymous closure function with arrow func --- test/parallel/test-http-localaddress.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-http-localaddress.js b/test/parallel/test-http-localaddress.js index 6763fae1265ac3..6e3bce6b9afec6 100644 --- a/test/parallel/test-http-localaddress.js +++ b/test/parallel/test-http-localaddress.js @@ -28,18 +28,18 @@ if (!common.hasMultiLocalhost()) const http = require('http'); const assert = require('assert'); -const server = http.createServer(function(req, res) { +const server = http.createServer((req, res) => { console.log(`Connect from: ${req.connection.remoteAddress}`); assert.strictEqual(req.connection.remoteAddress, '127.0.0.2'); - req.on('end', function() { + req.on('end', () => { res.writeHead(200, { 'Content-Type': 'text/plain' }); res.end(`You are from: ${req.connection.remoteAddress}`); }); req.resume(); }); -server.listen(0, '127.0.0.1', function() { +server.listen(0, '127.0.0.1', () => { const options = { host: 'localhost', port: this.address().port, path: '/', @@ -47,7 +47,7 @@ server.listen(0, '127.0.0.1', function() { localAddress: '127.0.0.2' }; const req = http.request(options, function(res) { - res.on('end', function() { + res.on('end', () => { server.close(); process.exit(); }); From 4b6d2947e1efbd0146c5897deb1d18d1ba82fafb Mon Sep 17 00:00:00 2001 From: "bisht11390@gmail.com" Date: Mon, 19 Nov 2018 21:36:15 +0530 Subject: [PATCH 4/6] Removed extra new line --- README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index f3376197eab81a..009288149d9cd4 100644 --- a/README.md +++ b/README.md @@ -62,7 +62,7 @@ The open source license grants you the freedom to use Node.js. It does not guarantee commitments of other people's time. Please be respectful and manage your expectations. -## Release Types +## Release Types * **Current**: Under active development. Code for the Current release is in the branch for its major version number (for example, @@ -591,4 +591,3 @@ Other keys used to sign some previous releases: [Working Groups]: https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md [Strategic Initiatives]: https://github.com/nodejs/TSC/blob/master/Strategic-Initiatives.md [#node.js channel on chat.freenode.net]: https://webchat.freenode.net?channels=node.js&uio=d4 - From 520b2aa0a6b8865f1be90dd181c81ec57db8dc30 Mon Sep 17 00:00:00 2001 From: "bisht11390@gmail.com" Date: Tue, 20 Nov 2018 10:32:07 +0530 Subject: [PATCH 5/6] removed changes on test-http-localaddress.js --- test/parallel/test-http-localaddress.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-http-localaddress.js b/test/parallel/test-http-localaddress.js index 6e3bce6b9afec6..6763fae1265ac3 100644 --- a/test/parallel/test-http-localaddress.js +++ b/test/parallel/test-http-localaddress.js @@ -28,18 +28,18 @@ if (!common.hasMultiLocalhost()) const http = require('http'); const assert = require('assert'); -const server = http.createServer((req, res) => { +const server = http.createServer(function(req, res) { console.log(`Connect from: ${req.connection.remoteAddress}`); assert.strictEqual(req.connection.remoteAddress, '127.0.0.2'); - req.on('end', () => { + req.on('end', function() { res.writeHead(200, { 'Content-Type': 'text/plain' }); res.end(`You are from: ${req.connection.remoteAddress}`); }); req.resume(); }); -server.listen(0, '127.0.0.1', () => { +server.listen(0, '127.0.0.1', function() { const options = { host: 'localhost', port: this.address().port, path: '/', @@ -47,7 +47,7 @@ server.listen(0, '127.0.0.1', () => { localAddress: '127.0.0.2' }; const req = http.request(options, function(res) { - res.on('end', () => { + res.on('end', function() { server.close(); process.exit(); }); From 4de002976e2c82e86b3775dc6e646ed54452c100 Mon Sep 17 00:00:00 2001 From: "bisht11390@gmail.com" Date: Tue, 20 Nov 2018 10:43:55 +0530 Subject: [PATCH 6/6] added back trailing space after release types --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 009288149d9cd4..533b36bf8dbd58 100644 --- a/README.md +++ b/README.md @@ -62,7 +62,7 @@ The open source license grants you the freedom to use Node.js. It does not guarantee commitments of other people's time. Please be respectful and manage your expectations. -## Release Types +## Release Types * **Current**: Under active development. Code for the Current release is in the branch for its major version number (for example,