From 340d52748f862e001f43f3fd016d5df58b1d9fb7 Mon Sep 17 00:00:00 2001 From: Julia Date: Wed, 14 Nov 2018 20:34:16 -0500 Subject: [PATCH 1/3] test: use destructuring for spawn import in test-pipewrap.js --- test/async-hooks/test-pipewrap.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/async-hooks/test-pipewrap.js b/test/async-hooks/test-pipewrap.js index f04f900606a3de..22c75c3a8073b5 100644 --- a/test/async-hooks/test-pipewrap.js +++ b/test/async-hooks/test-pipewrap.js @@ -8,7 +8,7 @@ const assert = require('assert'); const tick = require('../common/tick'); const initHooks = require('./init-hooks'); const { checkInvocations } = require('./hook-checks'); -const spawn = require('child_process').spawn; +const { spawn } = require('child_process').spawn; if (!common.isMainThread) common.skip('Worker bootstrapping works differently -> different async IDs'); From cd9eb17f72b41be48dc4048c7aa90ea5ce218c66 Mon Sep 17 00:00:00 2001 From: Julia Date: Wed, 14 Nov 2018 20:35:26 -0500 Subject: [PATCH 2/3] test: remove unused argument for onsleepExit() in test-pipewrap.js --- test/async-hooks/test-pipewrap.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/async-hooks/test-pipewrap.js b/test/async-hooks/test-pipewrap.js index 22c75c3a8073b5..ec4301ce592990 100644 --- a/test/async-hooks/test-pipewrap.js +++ b/test/async-hooks/test-pipewrap.js @@ -45,7 +45,7 @@ checkInvocations(processwrap, { init: 1 }, checkInvocations(x, { init: 1 }, 'pipe wrap when sleep.spawn was called'); }); -function onsleepExit(code) { +function onsleepExit() { checkInvocations(processwrap, { init: 1, before: 1 }, 'processwrap while in onsleepExit callback'); } From 6fc34ff3b960208f5baba48e66828f8cb84a7d7b Mon Sep 17 00:00:00 2001 From: Julia Date: Wed, 14 Nov 2018 20:47:26 -0500 Subject: [PATCH 3/3] test: fix spawn import in test-pipewrap.js --- test/async-hooks/test-pipewrap.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/async-hooks/test-pipewrap.js b/test/async-hooks/test-pipewrap.js index ec4301ce592990..a632115d228d64 100644 --- a/test/async-hooks/test-pipewrap.js +++ b/test/async-hooks/test-pipewrap.js @@ -8,7 +8,7 @@ const assert = require('assert'); const tick = require('../common/tick'); const initHooks = require('./init-hooks'); const { checkInvocations } = require('./hook-checks'); -const { spawn } = require('child_process').spawn; +const { spawn } = require('child_process'); if (!common.isMainThread) common.skip('Worker bootstrapping works differently -> different async IDs');