From aa9b473646612f02114e1d52b53f9bea67ed4f66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Santana=20Su=C3=A1rez?= Date: Tue, 6 Nov 2018 16:38:36 +0000 Subject: [PATCH 1/3] test: fixing arguments order in assert.strictEqual() --- test/parallel/test-http-1.0.js | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/test/parallel/test-http-1.0.js b/test/parallel/test-http-1.0.js index 47df50e2897b79..b2eeb26d580e0a 100644 --- a/test/parallel/test-http-1.0.js +++ b/test/parallel/test-http-1.0.js @@ -58,9 +58,9 @@ function test(handler, request_generator, response_validator) { { function handler(req, res) { - assert.strictEqual('1.0', req.httpVersion); - assert.strictEqual(1, req.httpVersionMajor); - assert.strictEqual(0, req.httpVersionMinor); + assert.strictEqual(req.httpVersion, '1.0'); + assert.strictEqual(req.httpVersionMajor, 1); + assert.strictEqual(req.httpVersionMinor, 0); res.writeHead(200, { 'Content-Type': 'text/plain' }); res.end(body); } @@ -72,8 +72,8 @@ function test(handler, request_generator, response_validator) { function response_validator(server_response, client_got_eof, timed_out) { const m = server_response.split('\r\n\r\n'); assert.strictEqual(m[1], body); - assert.strictEqual(true, client_got_eof); - assert.strictEqual(false, timed_out); + assert.strictEqual(client_got_eof, true); + assert.strictEqual(timed_out, false); } test(handler, request_generator, response_validator); @@ -86,9 +86,9 @@ function test(handler, request_generator, response_validator) { // { function handler(req, res) { - assert.strictEqual('1.0', req.httpVersion); - assert.strictEqual(1, req.httpVersionMajor); - assert.strictEqual(0, req.httpVersionMinor); + assert.strictEqual(req.httpVersion, '1.0'); + assert.strictEqual(req.httpVersionMajor, 1); + assert.strictEqual(req.httpVersionMinor, 0); res.sendDate = false; res.writeHead(200, { 'Content-Type': 'text/plain' }); res.write('Hello, '); res._send(''); @@ -113,8 +113,8 @@ function test(handler, request_generator, response_validator) { 'Hello, world!'; assert.strictEqual(expected_response, server_response); - assert.strictEqual(true, client_got_eof); - assert.strictEqual(false, timed_out); + assert.strictEqual(client_got_eof, true); + assert.strictEqual(timed_out, false); } test(handler, request_generator, response_validator); @@ -122,9 +122,9 @@ function test(handler, request_generator, response_validator) { { function handler(req, res) { - assert.strictEqual('1.1', req.httpVersion); - assert.strictEqual(1, req.httpVersionMajor); - assert.strictEqual(1, req.httpVersionMinor); + assert.strictEqual(req.httpVersion, '1.1'); + assert.strictEqual(req.httpVersionMajor, 1); + assert.strictEqual(req.httpVersionMinor, 1); res.sendDate = false; res.writeHead(200, { 'Content-Type': 'text/plain' }); res.write('Hello, '); res._send(''); @@ -156,8 +156,8 @@ function test(handler, request_generator, response_validator) { '\r\n'; assert.strictEqual(expected_response, server_response); - assert.strictEqual(true, client_got_eof); - assert.strictEqual(false, timed_out); + assert.strictEqual(client_got_eof, true); + assert.strictEqual(timed_out, false); } test(handler, request_generator, response_validator); From 7fe0ec436cf7e1053a629ce568fc601a2ca0e150 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Santana=20Su=C3=A1rez?= Date: Wed, 7 Nov 2018 10:16:47 +0000 Subject: [PATCH 2/3] test: fixing arguments order in assert.strictEqual() --- test/parallel/test-http-1.0.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-http-1.0.js b/test/parallel/test-http-1.0.js index b2eeb26d580e0a..b3ee136c385052 100644 --- a/test/parallel/test-http-1.0.js +++ b/test/parallel/test-http-1.0.js @@ -155,7 +155,7 @@ function test(handler, request_generator, response_validator) { '0\r\n' + '\r\n'; - assert.strictEqual(expected_response, server_response); + assert.strictEqual(server_response, expected_response); assert.strictEqual(client_got_eof, true); assert.strictEqual(timed_out, false); } From bce54bf0ef9027e03776dd3b974b199998e7d019 Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Wed, 7 Nov 2018 12:23:57 +0000 Subject: [PATCH 3/3] f: swap server_response expected_response --- test/parallel/test-http-1.0.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-http-1.0.js b/test/parallel/test-http-1.0.js index b3ee136c385052..134a5bb9853102 100644 --- a/test/parallel/test-http-1.0.js +++ b/test/parallel/test-http-1.0.js @@ -112,7 +112,7 @@ function test(handler, request_generator, response_validator) { '\r\n' + 'Hello, world!'; - assert.strictEqual(expected_response, server_response); + assert.strictEqual(server_response, expected_response); assert.strictEqual(client_got_eof, true); assert.strictEqual(timed_out, false); }