From fbe7afc005704e1b6c44eab7eba2b0814fc46958 Mon Sep 17 00:00:00 2001 From: Guy Bedford Date: Wed, 29 Nov 2017 10:58:11 +0200 Subject: [PATCH 1/2] doc: esm loader example with module.builtinModules --- doc/api/esm.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/doc/api/esm.md b/doc/api/esm.md index c352c24aa1c56d..c19592fbe78321 100644 --- a/doc/api/esm.md +++ b/doc/api/esm.md @@ -147,15 +147,13 @@ be written: import url from 'url'; import path from 'path'; import process from 'process'; +import module from 'module'; -const builtins = new Set( - Object.keys(process.binding('natives')).filter((str) => - /^(?!(?:internal|node|v8)\/)/.test(str)) -); +const builtins = module.builtinModules; const JS_EXTENSIONS = new Set(['.js', '.mjs']); export function resolve(specifier, parentModuleURL/*, defaultResolve */) { - if (builtins.has(specifier)) { + if (builtins.includes(specifier)) { return { url: specifier, format: 'builtin' From fa269398c6a913be5a83435a771af24dbefac3a8 Mon Sep 17 00:00:00 2001 From: Guy Bedford Date: Fri, 8 Dec 2017 11:50:03 +0200 Subject: [PATCH 2/2] use Module over module in example to avoid confusion --- doc/api/esm.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/esm.md b/doc/api/esm.md index c19592fbe78321..b812d7cb76db0b 100644 --- a/doc/api/esm.md +++ b/doc/api/esm.md @@ -147,9 +147,9 @@ be written: import url from 'url'; import path from 'path'; import process from 'process'; -import module from 'module'; +import Module from 'module'; -const builtins = module.builtinModules; +const builtins = Module.builtinModules; const JS_EXTENSIONS = new Set(['.js', '.mjs']); export function resolve(specifier, parentModuleURL/*, defaultResolve */) {