From e4a386d256f7485ce8bf00f1bcf73224bdf90fdc Mon Sep 17 00:00:00 2001 From: Sebastian Murphy Date: Sun, 7 May 2017 13:20:23 -0500 Subject: [PATCH 1/3] benchmark: convert var to es6 const, let Converted var variable to es6 const and let to maintain consistency with other benchmark files. Also clean up the types array to make the files more succinct. --- benchmark/arrays/var-int.js | 42 ++++++++++++++++------------------ benchmark/arrays/zero-float.js | 42 ++++++++++++++++------------------ benchmark/arrays/zero-int.js | 42 ++++++++++++++++------------------ 3 files changed, 60 insertions(+), 66 deletions(-) diff --git a/benchmark/arrays/var-int.js b/benchmark/arrays/var-int.js index 9ebad611661929..cd4ebec45132c8 100644 --- a/benchmark/arrays/var-int.js +++ b/benchmark/arrays/var-int.js @@ -1,38 +1,36 @@ 'use strict'; -var common = require('../common.js'); +const common = require('../common.js'); -var types = [ - 'Array', - 'Buffer', - 'Int8Array', - 'Uint8Array', - 'Int16Array', - 'Uint16Array', - 'Int32Array', - 'Uint32Array', - 'Float32Array', - 'Float64Array' -]; - -var bench = common.createBenchmark(main, { - type: types, +const bench = common.createBenchmark(main, { + type: [ + 'Array', + 'Buffer', + 'Int8Array', + 'Uint8Array', + 'Int16Array', + 'Uint16Array', + 'Int32Array', + 'Uint32Array', + 'Float32Array', + 'Float64Array' + ], n: [25] }); function main(conf) { - var type = conf.type; - var clazz = global[type]; - var n = +conf.n; + const type = conf.type; + const clazz = global[type]; + const n = +conf.n; bench.start(); - var arr = new clazz(n * 1e6); - for (var i = 0; i < 10; ++i) { + let arr = new clazz(n * 1e6); + for (let i = 0; i < 10; ++i) { run(); } bench.end(n); function run() { - for (var j = 0, k = arr.length; j < k; ++j) { + for (let j = 0, k = arr.length; j < k; ++j) { arr[j] = (j ^ k) & 127; } } diff --git a/benchmark/arrays/zero-float.js b/benchmark/arrays/zero-float.js index a74cd8ec5bacca..cc4b1d01e18837 100644 --- a/benchmark/arrays/zero-float.js +++ b/benchmark/arrays/zero-float.js @@ -1,38 +1,36 @@ 'use strict'; -var common = require('../common.js'); +const common = require('../common.js'); -var types = [ - 'Array', - 'Buffer', - 'Int8Array', - 'Uint8Array', - 'Int16Array', - 'Uint16Array', - 'Int32Array', - 'Uint32Array', - 'Float32Array', - 'Float64Array' -]; - -var bench = common.createBenchmark(main, { - type: types, +const bench = common.createBenchmark(main, { + type: [ + 'Array', + 'Buffer', + 'Int8Array', + 'Uint8Array', + 'Int16Array', + 'Uint16Array', + 'Int32Array', + 'Uint32Array', + 'Float32Array', + 'Float64Array' + ], n: [25] }); function main(conf) { - var type = conf.type; - var clazz = global[type]; - var n = +conf.n; + const type = conf.type; + const clazz = global[type]; + const n = +conf.n; bench.start(); - var arr = new clazz(n * 1e6); - for (var i = 0; i < 10; ++i) { + let arr = new clazz(n * 1e6); + for (let i = 0; i < 10; ++i) { run(); } bench.end(n); function run() { - for (var j = 0, k = arr.length; j < k; ++j) { + for (let j = 0, k = arr.length; j < k; ++j) { arr[j] = 0.0; } } diff --git a/benchmark/arrays/zero-int.js b/benchmark/arrays/zero-int.js index 7f61aa1a820042..4aed1126004325 100644 --- a/benchmark/arrays/zero-int.js +++ b/benchmark/arrays/zero-int.js @@ -1,38 +1,36 @@ 'use strict'; -var common = require('../common.js'); +const common = require('../common.js'); -var types = [ - 'Array', - 'Buffer', - 'Int8Array', - 'Uint8Array', - 'Int16Array', - 'Uint16Array', - 'Int32Array', - 'Uint32Array', - 'Float32Array', - 'Float64Array' -]; - -var bench = common.createBenchmark(main, { - type: types, +const bench = common.createBenchmark(main, { + type: [ + 'Array', + 'Buffer', + 'Int8Array', + 'Uint8Array', + 'Int16Array', + 'Uint16Array', + 'Int32Array', + 'Uint32Array', + 'Float32Array', + 'Float64Array' + ], n: [25] }); function main(conf) { - var type = conf.type; - var clazz = global[type]; - var n = +conf.n; + const type = conf.type; + const clazz = global[type]; + const n = +conf.n; bench.start(); - var arr = new clazz(n * 1e6); - for (var i = 0; i < 10; ++i) { + let arr = new clazz(n * 1e6); + for (let i = 0; i < 10; ++i) { run(); } bench.end(n); function run() { - for (var j = 0, k = arr.length; j < k; ++j) { + for (let j = 0, k = arr.length; j < k; ++j) { arr[j] = 0; } } From 11e0ee73ed7de49115b74bb83c1498d75080840b Mon Sep 17 00:00:00 2001 From: Sebastian Murphy Date: Sun, 7 May 2017 15:26:50 -0500 Subject: [PATCH 2/3] revert let to var --- benchmark/arrays/var-int.js | 6 +++--- benchmark/arrays/zero-float.js | 6 +++--- benchmark/arrays/zero-int.js | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/benchmark/arrays/var-int.js b/benchmark/arrays/var-int.js index cd4ebec45132c8..795d4eb838de2f 100644 --- a/benchmark/arrays/var-int.js +++ b/benchmark/arrays/var-int.js @@ -23,14 +23,14 @@ function main(conf) { const n = +conf.n; bench.start(); - let arr = new clazz(n * 1e6); - for (let i = 0; i < 10; ++i) { + var arr = new clazz(n * 1e6); + for (var i = 0; i < 10; ++i) { run(); } bench.end(n); function run() { - for (let j = 0, k = arr.length; j < k; ++j) { + for (var j = 0, k = arr.length; j < k; ++j) { arr[j] = (j ^ k) & 127; } } diff --git a/benchmark/arrays/zero-float.js b/benchmark/arrays/zero-float.js index cc4b1d01e18837..d61b0598a4ecf0 100644 --- a/benchmark/arrays/zero-float.js +++ b/benchmark/arrays/zero-float.js @@ -23,14 +23,14 @@ function main(conf) { const n = +conf.n; bench.start(); - let arr = new clazz(n * 1e6); - for (let i = 0; i < 10; ++i) { + var arr = new clazz(n * 1e6); + for (var i = 0; i < 10; ++i) { run(); } bench.end(n); function run() { - for (let j = 0, k = arr.length; j < k; ++j) { + for (var j = 0, k = arr.length; j < k; ++j) { arr[j] = 0.0; } } diff --git a/benchmark/arrays/zero-int.js b/benchmark/arrays/zero-int.js index 4aed1126004325..7d4e50e01c31b7 100644 --- a/benchmark/arrays/zero-int.js +++ b/benchmark/arrays/zero-int.js @@ -23,14 +23,14 @@ function main(conf) { const n = +conf.n; bench.start(); - let arr = new clazz(n * 1e6); + var arr = new clazz(n * 1e6); for (let i = 0; i < 10; ++i) { run(); } bench.end(n); function run() { - for (let j = 0, k = arr.length; j < k; ++j) { + for (var j = 0, k = arr.length; j < k; ++j) { arr[j] = 0; } } From 0cce53b587e8be09211b4affd8cc3f64cac76950 Mon Sep 17 00:00:00 2001 From: Sebastian Murphy Date: Sun, 7 May 2017 16:02:19 -0500 Subject: [PATCH 3/3] reverted let that i forgot --- benchmark/arrays/zero-int.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmark/arrays/zero-int.js b/benchmark/arrays/zero-int.js index 7d4e50e01c31b7..90d491e8073168 100644 --- a/benchmark/arrays/zero-int.js +++ b/benchmark/arrays/zero-int.js @@ -24,7 +24,7 @@ function main(conf) { bench.start(); var arr = new clazz(n * 1e6); - for (let i = 0; i < 10; ++i) { + for (var i = 0; i < 10; ++i) { run(); } bench.end(n);