From a5daef827da0074c66ae47364458351c256b8da5 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Fri, 28 Apr 2017 15:56:21 -0400 Subject: [PATCH 1/2] test: fix warning in n-api reference test Add cast to avoid warning during build of addon. --- test/addons-napi/test_reference/test_reference.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/addons-napi/test_reference/test_reference.c b/test/addons-napi/test_reference/test_reference.c index 1a238a560aac53..39cf49e703d5b9 100644 --- a/test/addons-napi/test_reference/test_reference.c +++ b/test/addons-napi/test_reference/test_reference.c @@ -61,7 +61,7 @@ napi_value CheckExternal(napi_env env, napi_callback_info info) { NAPI_ASSERT(env, argtype == napi_external, "Expected an external value.") int* data; - NAPI_CALL(env, napi_get_value_external(env, arg, &data)); + NAPI_CALL(env, napi_get_value_external(env, arg, (void*)&data)); NAPI_ASSERT(env, data != NULL && *data == test_value, "An external data value of 1 was expected.") From 4711d13a2b4358bc1560118343ca8aa694f4209a Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 1 May 2017 18:01:55 -0400 Subject: [PATCH 2/2] squash: address first set of comments --- test/addons-napi/test_reference/test_reference.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/addons-napi/test_reference/test_reference.c b/test/addons-napi/test_reference/test_reference.c index 39cf49e703d5b9..9be9fd135fb0e9 100644 --- a/test/addons-napi/test_reference/test_reference.c +++ b/test/addons-napi/test_reference/test_reference.c @@ -60,10 +60,10 @@ napi_value CheckExternal(napi_env env, napi_callback_info info) { NAPI_ASSERT(env, argtype == napi_external, "Expected an external value.") - int* data; - NAPI_CALL(env, napi_get_value_external(env, arg, (void*)&data)); + void* data; + NAPI_CALL(env, napi_get_value_external(env, arg, &data)); - NAPI_ASSERT(env, data != NULL && *data == test_value, + NAPI_ASSERT(env, data != NULL && *(int*)data == test_value, "An external data value of 1 was expected.") return NULL;