From ae00cb855a75139455ea4691d4e2158f652bcae7 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 29 Dec 2016 16:16:37 -0800 Subject: [PATCH 1/4] doc: require two-factor authentication Collaborators have elevated privileges. The CTC now requires Collaborator accounts to have two-factor authentication. This changes wording in the onboarding documentation to make it clear that two-factor authentication is required and not merely recommended. --- doc/onboarding.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 665890da968699..b9a08a45d59786 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -5,9 +5,9 @@ onboarding session. ## One week before the onboarding session -* Ask the new Collaborator if they are using two-factor authentication on their - GitHub account. If they are not, suggest that they enable it as their account - will have elevated privileges in many of the Node.js repositories. +* Confirm that the new Collaborator is using two-factor authentication on their + GitHub account. Collaborator accounts have elevated privileges and are + required to use two-factor authentication. ## Fifteen minutes before the onboarding session From 1f89fd9c6477589309fe1b295f528b5dbdf2506d Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 29 Dec 2016 16:22:49 -0800 Subject: [PATCH 2/4] squash: revise --- doc/onboarding.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index b9a08a45d59786..13389182c934d1 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -6,8 +6,9 @@ onboarding session. ## One week before the onboarding session * Confirm that the new Collaborator is using two-factor authentication on their - GitHub account. Collaborator accounts have elevated privileges and are - required to use two-factor authentication. + GitHub account. Without two-factor authentication enabled, accounts cannot be + given elevated privileges such as the ability to land code in the main + repository or to start continuous integration (CI) jobs. ## Fifteen minutes before the onboarding session From 3ea3db4fcdb14fecb090ab0c35965f8bc1ec5302 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 29 Dec 2016 16:24:44 -0800 Subject: [PATCH 3/4] squash: more revision --- doc/onboarding.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 13389182c934d1..eb1cb5da241a86 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -6,8 +6,8 @@ onboarding session. ## One week before the onboarding session * Confirm that the new Collaborator is using two-factor authentication on their - GitHub account. Without two-factor authentication enabled, accounts cannot be - given elevated privileges such as the ability to land code in the main + GitHub account. Unless two-factor authentication is enabled, do not give an + account elevated privileges such as the ability to land code in the main repository or to start continuous integration (CI) jobs. ## Fifteen minutes before the onboarding session From 848878c6db0a93ecb5b2cfa5f7bb935bd62cb643 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 29 Dec 2016 16:26:58 -0800 Subject: [PATCH 4/4] squash: even more revision --- doc/onboarding.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index eb1cb5da241a86..dbe3dfd569b7ae 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -12,8 +12,12 @@ onboarding session. ## Fifteen minutes before the onboarding session -* Prior to the onboarding session, add the new Collaborators to -[the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators). +* Prior to the onboarding session, add the new Collaborator to + [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators). + Note that this is the step that gives the account elevated privileges, so + do not perform this step (or any subsequent steps) unless two-factor + authentication is enabled on the new Collaborator's GitHub account. + ## Onboarding session