Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8DBG_OFF_FP_CONTEXT: Unknown variable name #8937

Closed
avysotsk opened this issue Oct 5, 2016 · 2 comments
Closed

V8DBG_OFF_FP_CONTEXT: Unknown variable name #8937

avysotsk opened this issue Oct 5, 2016 · 2 comments
Labels
build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. smartos Issues and PRs related to the SmartOS platform.

Comments

@avysotsk
Copy link

avysotsk commented Oct 5, 2016

  • Version: v4.6.0
  • Platform: SunOS testsystem 5.11 11.3 i86pc i386 i86pc
  • Subsystem:
Building node.js on Solaris X86 failed with the following error:
$ git clone https://github.com/nodejs/node.git
$ cd node
$ ./configure --dest-cpu=x64 --dest-os=solaris
$ CC=gcc gmake
[......skipped ...]
  LD_LIBRARY_PATH=/node/out/Release/lib.host:/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /node/out/Release/obj.target/node/src; dtrace -64 "-I/node/out/Release/obj/gen" -Isrc -C -G -s src/v8ustack.d -o "/node/out/Release/obj.target/node/src/node_dtrace_ustack.o"
dtrace: failed to compile script src/v8ustack.d: line 399: failed to resolve V8DBG_OFF_FP_CONTEXT: Unknown variable name
gmake[1]: *** [/node/out/Release/obj.target/node/src/node_dtrace_ustack.o] Error 1
rm 2d4051a96d22a31dce133be0905678af1e35363f.intermediate
gmake[1]: Leaving directory `/node/out'
gmake: *** [node] Error 2

I did a find for this variable, but looks like it was not defined. 
$ find . -exec grep V8DBG_OFF_FP_CONTEXT {} \; -print
grep: can't open ./tools/eslint/node_modules/.bin/eslint
#define V8_OFF_FP_CONTEXT           V8DBG_OFF_FP_CONTEXT
./src/v8abbr.h
$ 
@bnoordhuis
Copy link
Member

Sounds a lot like #1967 and #7840. I don't think we ever truly resolved those issues but the reporter from the second issue reported that upgrading to v6.x fixed the issue for them; upgrading your toolchain, binutils in particular, may help too. If all else fails, build with ./configure --without-dtrace && make.

FWIW, the symbol is generated by deps/v8/tools/gen-postmortem-metadata.py; grep for 'off_fp_context'. It maps to StandardFrameConstants::kContextOffset, which is certainly in use.

@bnoordhuis bnoordhuis added build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. smartos Issues and PRs related to the SmartOS platform. labels Oct 5, 2016
@avysotsk
Copy link
Author

avysotsk commented Oct 5, 2016

Updating binutils from 2.23.1 to 2.26 resolved the issue. I think the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. smartos Issues and PRs related to the SmartOS platform.
Projects
None yet
Development

No branches or pull requests

2 participants