-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UV_USE_IO_URING does not update file handle position #55113
Comments
Yes, ordering in the handling of requests sent to the ring is not guaranteed. So you're right, the offset should be properly set when calling |
I think we should throw in |
@nodejs/tsc I think this is so bad that we should just remove |
This should not be an issue once |
Didn't we disable UV_USE_IO_URING by default everywhere? |
Yes, referring to a security issue. But some users like us enable it without knowing that here be dragons. |
@ronag wait, I'm not familiar with the internals of the streams. Can those |
They are sequential. |
Ok, can you share a reproducer? |
I suspect possible regression. Not sure what version but must have been recent:
Will not create a full sized file. I suspect that since
createWriteStream
doesn't explicitly setposition
during writes it expects the file handle position to be properly updated, which does not seem to be the case with URING.The text was updated successfully, but these errors were encountered: