Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: parallel/test-worker-node-options fails on IBM i #53852

Closed
abmusse opened this issue Jul 15, 2024 · 1 comment · Fixed by #53952
Closed

test: parallel/test-worker-node-options fails on IBM i #53852

abmusse opened this issue Jul 15, 2024 · 1 comment · Fixed by #53952
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. ibm i Issues and PRs related to the IBM i platform.

Comments

@abmusse
Copy link
Contributor

abmusse commented Jul 15, 2024 

not ok 3633 parallel/test-worker-node-options
   ---
   duration_ms: 3453.04000
   severity: fail
   exitcode: 1
   stack: |-
     [process 52215849]: --- stderr ---
     node:assert:126
       throw new AssertionError(obj);
       ^
     
     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
     
     '' !== 'foo'
     
         at Object.<anonymous> (/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/test/fixtures/spawn-worker-with-copied-env.js:6:10)
         at Module._compile (node:internal/modules/cjs/loader:1458:14)
         at Module._extensions..js (node:internal/modules/cjs/loader:1542:10)
         at Module.load (node:internal/modules/cjs/loader:1282:32)
         at Module._load (node:internal/modules/cjs/loader:1098:12)
         at TracingChannel.traceSync (node:diagnostics_channel:315:14)
         at wrapModuleLoad (node:internal/modules/cjs/loader:215:24)
         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:158:5)
         at node:internal/main/run_main_module:30:49 {
       generatedMessage: true,
       code: 'ERR_ASSERTION',
       actual: '',
       expected: 'foo',
       operator: 'strictEqual'
     }

ref: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/lastBuild/testReport/
@RedYetiDev RedYetiDev added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 15, 2024
@abmusse
Copy link
Contributor Author

abmusse commented Jul 16, 2024 •
edited
Loading

Seems like IBM i has the same issue as SmartOS and will most likely need the same conditional

node/test/fixtures/spawn-worker-with-copied-env.js

Lines 4 to 7 in 3a5b542

const assert = require('assert');
if (process.platform !== 'sunos') { // --title is unsupported on SmartOS.
assert.strictEqual(process.title, 'foo');
}

@richardlau richardlau added the ibm i Issues and PRs related to the IBM i platform. label Jul 16, 2024
@abmusse abmusse mentioned this issue Jul 19, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue Jul 22, 2024
@abmusse
test: skip --title check on IBM i
c83af17 
Similar to SmartOS IBM i does not return the process.title

PR-URL: #53952
Fixes: #53852
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jul 28, 2024
@abmusse @targos
test: skip --title check on IBM i
68b8412 
Similar to SmartOS IBM i does not return the process.title

PR-URL: #53952
Fixes: #53852
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this issue Aug 5, 2024
@abmusse @RafaelGSS
test: skip --title check on IBM i
30a94ca 
Similar to SmartOS IBM i does not return the process.title

PR-URL: #53952
Fixes: #53852
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this issue Aug 19, 2024
@abmusse @marco-ippolito
test: skip --title check on IBM i
f03b6a4 
Similar to SmartOS IBM i does not return the process.title

PR-URL: #53952
Fixes: #53852
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this issue Aug 19, 2024
@abmusse @marco-ippolito
test: skip --title check on IBM i
5b0af4f 
Similar to SmartOS IBM i does not return the process.title

PR-URL: #53952
Fixes: #53852
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this issue Aug 19, 2024
@abmusse @marco-ippolito
test: skip --title check on IBM i
56c26fe 
Similar to SmartOS IBM i does not return the process.title

PR-URL: #53952
Fixes: #53852
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. ibm i Issues and PRs related to the IBM i platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: skip --title check on IBM i abmusse/node
3 participants
@richardlau @abmusse @RedYetiDev