Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major bug was fixed in NPM@10.3.0 concerning apps started with npm start #51923

Closed
zotakk4o opened this issue Feb 29, 2024 · 9 comments
Closed
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.

Comments

@zotakk4o
Copy link

Version

20.11.0

Platform

Any

Subsystem

No response

What steps will reproduce the bug?

There was an bug introduced in earlier versions of npmcli/run-script 6.0.2 which prevented signals from reaching child processes of NPM, i.e. applications started with npm start. This is fixed in 10.3.0 of the NPM package. Link to issue npm/run-script@089eefb.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

Child processes of NPM should receive signals so that they can handle proper shutdown(SIGTERM, SIGINT, etc.)

What do you see instead?

Child processes of NPM are not killed properly, meaning that shutdown processes are no longer executed for nodejs applications started with npm start

Additional information

The Docker team was informed about the problem but responded that Node must update the NPM package available for their versions. nodejs/docker-node#2038

@zotakk4o zotakk4o changed the title Major bug was fixed in NPM@10.3.0 concerning containerized apps Major bug was fixed in NPM@10.3.0 concerning apps started with npm start Feb 29, 2024
@richardlau
Copy link
Member

This is a duplicate of #48946.

npm 10.3.0 is on main (#51431) but hasn't gone out in a Node.js 21 release yet. Our usual policy would be for things to be released in a current release (i.e. Node.js 21) first for two weeks before it would be eligible for inclusion in long-term support releases (i.e. Node.js 20 and 18).

@richardlau richardlau added the npm Issues and PRs related to the npm client dependency or the npm registry. label Feb 29, 2024
@zotakk4o
Copy link
Author

Do you know when the next Node.js 21 release is going live?

@richardlau
Copy link
Member

Do you know when the next Node.js 21 release is going live?

It was planned for last week but I'm not sure why it didn't happen as I was away.
cc @nodejs/releasers

@marco-ippolito
Copy link
Member

marco-ippolito commented Feb 29, 2024

@richardlau there were some issue with the CI flakiness making impossible to backport.
I guess as soon as this land #51898 I can create the proposal for 21.
The NPM was just updated and will be pulled in 21.7

@marco-ippolito
Copy link
Member

node 21.7.0 has been live for around a week, I would consider this solved

@zotakk4o
Copy link
Author

Hi, team, any idea when the updated NPM is coming to LTS, for example 20.11.1, versions? A lot of NodeJs applications that are being launched with "npm start" don't work now causing interruption of DB queries, HTTP requests, etc.

@marco-ippolito
Copy link
Member

Hi, team, any idea when the updated NPM is coming to LTS, for example 20.11.1, versions? A lot of NodeJs applications that are being launched with "npm start" don't work now causing interruption of DB queries, HTTP requests, etc.

AFAIK release for 20 is planned for 2024-03-26 @richardlau

@zotakk4o
Copy link
Author

Hi, team, any updates? Shall I expect a delay in the release of NPM@10.5.0 for older node versions?

@richardlau
Copy link
Member

I'm hoping to get #52212 and #52165 out later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

No branches or pull requests

3 participants