Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX - test-tick-processor.js #5088

Closed
mhdawson opened this issue Feb 4, 2016 · 9 comments
Closed

AIX - test-tick-processor.js #5088

mhdawson opened this issue Feb 4, 2016 · 9 comments
Assignees
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

mhdawson commented Feb 4, 2016

Failure on AIX in newly added CI run

https://ci.nodejs.org/job/node-test-commit-aix/33/nodes=aix61-ppc64/console

not ok 765 test-tick-processor.js
# TIMEOUT
  ---
  duration_ms: 60.204
  ...
@mhdawson mhdawson self-assigned this Feb 4, 2016
@mhdawson mhdawson added the master label Feb 4, 2016
@mhdawson
Copy link
Member Author

mhdawson commented Feb 4, 2016

Related to #2957 but I believe in a different test.

Will use this issue to track excluding for AIX until 2957 is resolved.

@Trott Trott added the test Issues and PRs related to the tests. label Feb 4, 2016
@mhdawson
Copy link
Member Author

mhdawson commented Feb 4, 2016

Based on investigation by @stefanmb the issue is because the v8 scripts rely on the valid address range being less than the full 64 bits. Since AIX supports the full 64 bits and some must be in the upper range the script does not handle the addresses correctly, and ends up running out of memory.

@stefanmb
Copy link
Contributor

stefanmb commented Feb 4, 2016

@mhdawson I can't actually view the failure since I don't have permissions in Jenkins. However, assuming it's the tick-processor out-of-memory timeout, credit actually goes to @mtbrandy for figuring out the address range problem. I've done a proof of concept of V8 tooling with Big Integer support here: https://github.com/stefanmb/v8/tree/v8-tooling-bigint

I'll clean it up tomorrow and we can decide what to do with it.

@mhdawson
Copy link
Member Author

mhdawson commented Feb 4, 2016

Jenkins is temporarily locked down to collaborators you will be able to see it later on.

@Trott
Copy link
Member

Trott commented Feb 4, 2016

/cc @matthewloring

@mhdawson
Copy link
Member Author

mhdawson commented Feb 4, 2016

PR to temporarily disable on AIX until we get an v8 fix upstreamed so we can get CI green

#5093

@mscdex mscdex added the lib / src Issues and PRs related to general changes in the lib or src directory. label Feb 5, 2016
@stefanmb
Copy link
Contributor

stefanmb commented Feb 5, 2016

@mhdawson I've updated my Big Integer branch linked above, at the moment it's an ugly hack but using it the tooling successfully parses the AIX PPC logs, and the unit tests from V8 ('make x64.check') pass as well. I'll wait on some more feedback from others to see if this is the direction we want to take in V8 itself.

@Trott
Copy link
Member

Trott commented Feb 6, 2016

It may not be possible, but anything that can be done to make the test more deterministic would be great. It's been the source of a fair bit of flakiness.

@mhdawson
Copy link
Member Author

excluded for now under #5093 and added ref to that PR in #2957 so that we remember to disable. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants