-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIX - test-tick-processor.js #5088
Comments
Related to #2957 but I believe in a different test. Will use this issue to track excluding for AIX until 2957 is resolved. |
Based on investigation by @stefanmb the issue is because the v8 scripts rely on the valid address range being less than the full 64 bits. Since AIX supports the full 64 bits and some must be in the upper range the script does not handle the addresses correctly, and ends up running out of memory. |
@mhdawson I can't actually view the failure since I don't have permissions in Jenkins. However, assuming it's the tick-processor out-of-memory timeout, credit actually goes to @mtbrandy for figuring out the address range problem. I've done a proof of concept of V8 tooling with Big Integer support here: https://github.com/stefanmb/v8/tree/v8-tooling-bigint I'll clean it up tomorrow and we can decide what to do with it. |
Jenkins is temporarily locked down to collaborators you will be able to see it later on. |
/cc @matthewloring |
PR to temporarily disable on AIX until we get an v8 fix upstreamed so we can get CI green |
@mhdawson I've updated my Big Integer branch linked above, at the moment it's an ugly hack but using it the tooling successfully parses the AIX PPC logs, and the unit tests from V8 ('make x64.check') pass as well. I'll wait on some more feedback from others to see if this is the direction we want to take in V8 itself. |
It may not be possible, but anything that can be done to make the test more deterministic would be great. It's been the source of a fair bit of flakiness. |
Failure on AIX in newly added CI run
https://ci.nodejs.org/job/node-test-commit-aix/33/nodes=aix61-ppc64/console
The text was updated successfully, but these errors were encountered: