-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url.parse regression in 18.17+ #49330
Comments
👀 Just noting that this does work with
|
If I had to guess, Ada 2.x is the cause of this? It was landed in 18.17.0: #48345 |
#45514 seems to be another similar issue from the past, though not as niche as this one. I've opened raineorshine/npm-check-updates#1319 with a library I use that broke due to this when used with npm aliases, so hopefully things will be fixed there. But I do worry if there's other older libraries in the ecosystem that might see impact here too. |
This issue is fixed with #48873 and will be part of the next Node 18 release. |
Version
v18.17.1
Platform
Microsoft Windows NT 10.0.19045.0 x64
Subsystem
No response
What steps will reproduce the bug?
18.17.1
18.16.0
What do you see instead?
18.17.1 throws a
ERR_INVALID_URL
TypeError
instead of returning theURL
object as per 18.16.0 and prior.Additional information
This string seems to parse fine using
new URL('npm:postman-request@2.88.1-postman.33')
in both18.16.0
and18.17.1
.In 18.17:
PARSES:
npm:postman-request@2.88.1
PARSES:
npm:postman-request@2.88.1-postman
PARSES:
npm:postman-request@2.88.1-postman.
FAILS:
npm:postman-request@2.88.1-postman.33
PARSES:
schema:something@1.0.0
PARSES:
schema:something@1.0.0-p
FAILS:
schema:something@1.0.0-p.1
In 18.16, all parse fine.
The text was updated successfully, but these errors were encountered: