Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: ClientRequest should extend OutgoingMessage in the docs #35057

Closed
1 task
mmarchini opened this issue Sep 4, 2020 · 2 comments
Closed
1 task

doc: ClientRequest should extend OutgoingMessage in the docs #35057

mmarchini opened this issue Sep 4, 2020 · 2 comments
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Comments

@mmarchini
Copy link
Contributor

📗 API Reference Docs Problem

  • Version: all
  • Platform: n/a
  • Subsystem: http

Location

Affected URL(s):

Description

ClientRequest extends OutgoingMessage, but the documentation says it extends Stream, which is not entirely incorrect since OutgoingMessage extends Stream, but users might not be aware that methods from OutgoingMessage are available on ClientRequest as well.

Depends on #33847 since OutgoingMessage is not documented at the moment.


  • I would like to work on this issue and
    submit a pull request.
@mmarchini mmarchini added the doc Issues and PRs related to the documentations. label Sep 4, 2020
@targos targos added the http Issues or PRs related to the http subsystem. label Aug 9, 2021
@himadriganguly
Copy link
Contributor

I will like to pick this up.

@y1d7ng
Copy link
Contributor

y1d7ng commented Apr 28, 2022

@mmarchini @aduh95 @targos Looks like this issue has been fixed, can it be closed?

@targos targos closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants