Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC 8032 / RFC 7748 (Elliptic Curves for Security) to crypto.getCurves() #30097

Closed
paragonie-scott opened this issue Oct 23, 2019 · 3 comments
Labels
crypto Issues and PRs related to the crypto subsystem. feature request Issues that request new features to be added to Node.js. openssl Issues and PRs related to the OpenSSL dependency.

Comments

@paragonie-scott
Copy link

paragonie-scott commented Oct 23, 2019

Run this code (I'm using Node.js 12.13.0 from deb.nodesource.com):

const crypto = require('crypto');
console.log(crypto.getCurves());

Absent from this list are the curves recommended in RFC 7748 (Elliptic Curves for Security). Additionally, RFC 8032 (EdDSA) is not supported either.

For ECDH, I would expect to see x25519 and x448 in the list.
For signatures, I would expect to see ed25519 and ed448 as well.

Note: These types are documented elsewhere:

@paragonie-scott paragonie-scott changed the title ADd RFC 8032 / RFC 7748 (Elliptic Curves for Security) to crypto.getCurves() Add RFC 8032 / RFC 7748 (Elliptic Curves for Security) to crypto.getCurves() Oct 23, 2019
@ChALkeR
Copy link
Member

ChALkeR commented Oct 23, 2019

@paragonie-scott That basically exposes OpenSSL EC_get_builtin_curves, and should probably match with openssl ecparam -list_curves for the OpenSSL version used.

@ChALkeR ChALkeR added crypto Issues and PRs related to the crypto subsystem. feature request Issues that request new features to be added to Node.js. openssl Issues and PRs related to the OpenSSL dependency. labels Oct 23, 2019
@paragonie-scott
Copy link
Author

Ah, this looks to be a known behavior of OpenSSL. openssl/openssl#8880 (comment)

Okay, not much we can do here then. :(

@ChALkeR
Copy link
Member

ChALkeR commented Oct 23, 2019

@nodejs/documentation Anything here that should be mentioned in the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. feature request Issues that request new features to be added to Node.js. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

No branches or pull requests

2 participants