-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures with TERM=dumb
#28064
Comments
@richardlau I've been looking into this, too, trying to identify the root cause, it looks like you have figure it out. Do you know where the TERM is set to that, so that we can change it? I've been looking, and haven't found it yet. I have a suspicion that it is inherited from whatever user manually sshed in and restarted the jenkins service, which could explain why these problems cleared away when I restarted jenkins on be-2 last week (my TERM is usally either I started making the tests more robust yesterday: 9132037 If they can all be made more robust as simply as test-console-clear, I'll do that. |
Unfortunately I don't know (my experience of
I came up with richardlau@b3b9e7e for test-console-clear but the next test I looked at before I left the office today (test-readline-position) looked trickier to fix. |
I does look like TERM is inherited from java's env:
I restarted jenkins on be-2, it now has my TERM value. I'll PR a change to the rc scripts to ensure TERM always gets a consistent value. |
@sam-github so that would mean that when-ever the agent was restarted we might have gotten a different TERM value? If so that would explain the behaviour we've seen and that restarting the jenkins agent can fix it. Assuming I've understood correctly ensuring that TERM is set in the rc scripts sounds good :) |
Some tests, e.g. parallel/test-console-clear, fail when the
TERM
environment variable isdumb
, e.g. on Linux:Noticed on our CI, where tests are failing on one of the AIX executors, test-osuosl-aix61-ppc64_be-2, which has
TERM
set todumb
according to Jenkins, e.g. https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/23627/. (The other two AIX executors haveTERM
set toxterm
andscreen-256color
and the tests pass on them.)I guess there are two issues here:
TERM=dumb
(either they should pass or at least skip)TERM
setting (cc @nodejs/build-infra @nodejs/platform-aix)The twelve failing tests
The text was updated successfully, but these errors were encountered: