Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use build_release target in vcbuild.bat to build releases #2516

Closed
rvagg opened this issue Aug 24, 2015 · 4 comments
Closed

build: use build_release target in vcbuild.bat to build releases #2516

rvagg opened this issue Aug 24, 2015 · 4 comments
Assignees
Labels
build Issues and PRs related to build files or the CI.
Milestone

Comments

@rvagg
Copy link
Member

rvagg commented Aug 24, 2015

Currently Jenkins is doing this for iojs+release:

vcbuild.bat release msi %ARCH% upload

But 1f12e032 introduced the build_release target that was in joyent/node (also see nodejs/node-convergence-archive#27). We should be using that, perhaps:

vcbuild.bat build-release upload

Needs investigation to make sure it doesn't break stuff. It would seem right now that our Windows releases don't have Intl enabled because of this.

@rvagg rvagg self-assigned this Aug 24, 2015
@rvagg rvagg added this to the 4.0.0 milestone Aug 24, 2015
@ChALkeR ChALkeR added the build Issues and PRs related to build files or the CI. label Aug 24, 2015
@rvagg rvagg mentioned this issue Aug 24, 2015
10 tasks
@rvagg
Copy link
Member Author

rvagg commented Sep 4, 2015

FYI this isn't holding up release ("A .bat file is holding up the whole thing!"—hackernews), it should be completed by recent commits to core, I'm leaving this open as a reminder to confirm that it's working as expected in the 4.0 RC builds.

@timdorr
Copy link

timdorr commented Sep 4, 2015

Heh, that was me. Sorry about that. No drama intended :)

@Fishrock123
Copy link
Contributor

@rvagg is this done now? It's marked off in the timeline.

@rvagg rvagg closed this as completed Sep 8, 2015
@rvagg
Copy link
Member Author

rvagg commented Sep 8, 2015

seems to be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

4 participants