Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing agent should maybe support shutdown-on-signal #22883

Closed
addaleax opened this issue Sep 16, 2018 · 3 comments
Closed

Tracing agent should maybe support shutdown-on-signal #22883

addaleax opened this issue Sep 16, 2018 · 3 comments
Labels
feature request Issues that request new features to be added to Node.js. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. stale trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.

Comments

@addaleax
Copy link
Member

#22734 removed this feature because the implementation was inherently broken/flaky and not easily fixable.

A new implementation of it would likely require some significant structural changes to the tracing implementation.

/cc @nodejs/diagnostics
@addaleax addaleax added feature request Issues that request new features to be added to Node.js. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Sep 16, 2018
@Trott Trott added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Nov 22, 2018
@sladyn98
Copy link

@addaleax @refack I would like to be able to solve this issue.
As far as I understand we need the tracing acgent to be graceful on exit with a shutdown on signal function as well.May I understand how do we plan to proceed with the implementation.Thanks

@Flarna Flarna mentioned this issue Jan 18, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Mar 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. stale trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Trott @addaleax @trivikr @sladyn98