Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky sequential/test-benchmark-http times out on AIX #20389

Closed
addaleax opened this issue Apr 28, 2018 · 8 comments
Closed

Flaky sequential/test-benchmark-http times out on AIX #20389

addaleax opened this issue Apr 28, 2018 · 8 comments
Labels
aix Issues and PRs related to the AIX platform. benchmark Issues and PRs related to the benchmark subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.

Comments

@addaleax
Copy link
Member

  • Version: master
  • Platform: AIX
  • Subsystem: benchmark/http

There are timeouts showing in https://ci.nodejs.org/job/node-stress-single-test/1828/nodes=aix61-ppc64/console… not sure how to debug this. :/

Example CI failure
16:34:01 not ok 1 sequential/test-benchmark-http
16:34:01   ---
16:34:01   duration_ms: 120.313
16:34:01   severity: fail
16:34:01   exitcode: -15
16:34:01   stack: |-
16:34:01     timeout
16:34:01     
16:34:01     http/bench-parser.js
16:34:01     http/bench-parser.js n=1 len=1: 6,508.848779916296
16:34:01     
16:34:01     http/check_invalid_header_char.js
16:34:01     http/check_invalid_header_char.js n=1 input="keep-alive": 4,910.433689503457
16:34:01     
16:34:01     http/check_is_http_token.js
16:34:01     http/check_is_http_token.js n=1 key="\"\"": 6,628.091176022218
16:34:01     
16:34:01     http/chunked.js
16:34:01     http/chunked.js c=1 len=1 n=1 benchmarker="test-double": 1
16:34:01     
16:34:01     http/client-request-body.js
16:34:01     http/client-request-body.js method="write" len=1 type="asc" dur=0.1: 1,872.847874892965
16:34:01     
16:34:01     http/cluster.js
16:34:01     http/cluster.js c=1 len=1 type="asc" benchmarker="test-double": 1
16:34:01   ...
@addaleax addaleax added http Issues or PRs related to the http subsystem. benchmark Issues and PRs related to the benchmark subsystem. aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Apr 28, 2018
@Trott
Copy link
Member

Trott commented Apr 28, 2018

Running it on the command line, I can see that the next benchmark would be http/create-clientrequest.js, so somehow it would seem that benchmark is getting in an infinite loop or similar state on AIX. At least, that would be my first guess.

@Trott
Copy link
Member

Trott commented Apr 28, 2018

(Also, that benchmark is being called with n=1 and len=1.)

@gireeshpunathil
Copy link
Member

#define ENOTBLK 15 /* Block device required

“Block device required.” A file that isn’t a block special file was given in a situation that requires one. For example, trying to mount an ordinary file as a file system in Unix gives this error.

Definition of the error code reported is not meaningful to any source line in the benchmark in question. I would declare it as an infra issue.

@gireeshpunathil
Copy link
Member

or -15 is thrown by the test suite in response to a timed out test?

@addaleax
Copy link
Member Author

@gireeshpunathil -15 is -SIGTERM, which is the signal that the test runner uses for timeouts

@gireeshpunathil
Copy link
Member

ok thanks, I messed up exit code with errno.

Unable to reproduce locally, after a 1000 runs! will review the code to see any potential for a hang.

@apapirovski
Copy link
Member

It's very likely to be the cluster benchmark. Yes, it finishes but the cluster likely doesn't shut down correctly. This would also align with the other recent CI failures around the cluster module (e.g. on OS X where child processes have been getting left behind recently). Chances are we're exposing a recently introduced bug in all this.

@apapirovski
Copy link
Member

I think this might've been fixed? I'll close it out and we can reopen if it fails again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. benchmark Issues and PRs related to the benchmark subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants