Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new label fast-track? #16877

Closed
joyeecheung opened this issue Nov 8, 2017 · 5 comments
Closed

Add a new label fast-track? #16877

joyeecheung opened this issue Nov 8, 2017 · 5 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Nov 8, 2017

We've decided in #16135 to fast-track certain types of PRs (mostly test-only and doc-only PRs), also we need to expedite some PR fixing regressions or CI from time to time as well, maybe we can just use a new label to make those decisions clearer? I am thinking about fast-track at the moment.

Refs: https://github.com/joyeecheung/node-core-utils/pull/92
Refs: https://github.com/joyeecheung/node-core-utils/pull/94

@joyeecheung joyeecheung added the meta Issues and PRs related to the general management of the project. label Nov 8, 2017
@mhdawson
Copy link
Member

mhdawson commented Nov 8, 2017

Can you put together a couple of sentence description for what 'fast-track' would mean ? I'm wondering if it is meant to just be informational, a request to get agreement that a PR can be fast tracked or if its also a request to jump in and help get it reviewed/landed quickly ?

@joyeecheung
Copy link
Member Author

@mhdawson

I am leaning towrads "a request to get agreement that a PR can be fast tracked", meaning this should be landable after n approvals have been made (the number n needs discussion, of course). I will open a PR later to document this in the collaborator guide, that way it would be easier for us to discuss about the actual process (text changes).

@refack
Copy link
Contributor

refack commented Nov 10, 2017

I created the label. Without new wording in the collaborator guide, current policy is:

Trivial changes (e.g. those which fix minor bugs or improve performance without affecting API or causing other wide-reaching impact), and focused changes that affect only documentation and/or the test suite, may be landed after a shorter delay if they have multiple approvals.

So I would consider the use of this label as a declaration of intent so people can request to take it slow, and also for traceability of the decision process.

@maclover7
Copy link
Contributor

@joyeecheung since the fast-track label has been created, this can be closed, right? (wasn't sure, wanted to double check)

@joyeecheung
Copy link
Member Author

@maclover7 Yes, thanks for the reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

4 participants