Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test-npm produces files that are not ignored #1549

Closed
Fishrock123 opened this issue Apr 28, 2015 · 1 comment
Closed

make test-npm produces files that are not ignored #1549

Fishrock123 opened this issue Apr 28, 2015 · 1 comment
Labels
test Issues and PRs related to the tests.

Comments

@Fishrock123
Copy link
Contributor

The result after running make test-npm:

diff --git a/deps/npm/node_modules/.bin/mkdirp b/deps/npm/node_modules/.bin/mkdirp
new file mode 120000
index 0000000..017896c
--- /dev/null
+++ b/deps/npm/node_modules/.bin/mkdirp
@@ -0,0 +1 @@
+../mkdirp/bin/cmd.js
\ No newline at end of file
diff --git a/deps/npm/node_modules/.bin/node-gyp b/deps/npm/node_modules/.bin/node-gyp
new file mode 120000
index 0000000..9b31a4f
--- /dev/null
+++ b/deps/npm/node_modules/.bin/node-gyp
@@ -0,0 +1 @@
+../node-gyp/bin/node-gyp.js
\ No newline at end of file
diff --git a/deps/npm/node_modules/.bin/nopt b/deps/npm/node_modules/.bin/nopt
new file mode 120000
index 0000000..6b6566e
--- /dev/null
+++ b/deps/npm/node_modules/.bin/nopt
@@ -0,0 +1 @@
+../nopt/bin/nopt.js
\ No newline at end of file
diff --git a/deps/npm/node_modules/.bin/opener b/deps/npm/node_modules/.bin/opener
new file mode 120000
index 0000000..120b591
--- /dev/null
+++ b/deps/npm/node_modules/.bin/opener
@@ -0,0 +1 @@
+../opener/opener.js
\ No newline at end of file
diff --git a/deps/npm/node_modules/.bin/rimraf b/deps/npm/node_modules/.bin/rimraf
new file mode 120000
index 0000000..4cd49a4
--- /dev/null
+++ b/deps/npm/node_modules/.bin/rimraf
@@ -0,0 +1 @@
+../rimraf/bin.js
\ No newline at end of file
diff --git a/deps/npm/node_modules/.bin/semver b/deps/npm/node_modules/.bin/semver
new file mode 120000
index 0000000..317eb29
--- /dev/null
+++ b/deps/npm/node_modules/.bin/semver
@@ -0,0 +1 @@
+../semver/bin/semver
\ No newline at end of file
diff --git a/deps/npm/node_modules/.bin/strip-ansi b/deps/npm/node_modules/.bin/strip-ansi
new file mode 120000
index 0000000..b65c9f8
--- /dev/null
+++ b/deps/npm/node_modules/.bin/strip-ansi
@@ -0,0 +1 @@
+../strip-ansi/cli.js
\ No newline at end of file
diff --git a/deps/npm/node_modules/.bin/which b/deps/npm/node_modules/.bin/which
new file mode 120000
index 0000000..f62471c
--- /dev/null
+++ b/deps/npm/node_modules/.bin/which
@@ -0,0 +1 @@
+../which/bin/which
\ No newline at end of file
diff --git a/deps/npm/test/fixtures/config/userconfig-with-gc b/deps/npm/test/fixtures/config/userconfig-with-gc
index 7268fcb..d79c625 100644
--- a/deps/npm/test/fixtures/config/userconfig-with-gc
+++ b/deps/npm/test/fixtures/config/userconfig-with-gc
@@ -1,4 +1,4 @@
-globalconfig=/Users/ogd/Documents/projects/npm/npm/test/fixtures/config/globalconfig
+globalconfig=/Users/Jeremiah/Documents/io.js/deps/npm/test/fixtures/config/globalconfig
 email=i@izs.me
 env-thing=asdf
 init.author.name=Isaac Z. Schlueter

Should deps/npm/node_modules/.bin be checked in with npm, or ignored?

Also, the last file appears to regenerate itself and change to the user's path upon running the tests...

cc @othiym23?

@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Apr 28, 2015
@Fishrock123
Copy link
Contributor Author

Fixed by 0b21ab1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

1 participant