Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteria for n-api to exit experimental status #14532

Closed
digitalinfinity opened this issue Jul 28, 2017 · 7 comments
Closed

Criteria for n-api to exit experimental status #14532

digitalinfinity opened this issue Jul 28, 2017 · 7 comments
Labels
meta Issues and PRs related to the general management of the project. node-api Issues and PRs related to the Node-API.

Comments

@digitalinfinity
Copy link
Contributor

digitalinfinity commented Jul 28, 2017

At VM Summit #4, a rough criteria was formulated for n-api to exit experimental status. The consensus was that this criteria needs to be refined further, and this issue is meant to facilitate that discussion.

Current criteria:

    • Multiple implementations of n-api on at least 2 VMs
    • At least two modules that are NPM installable with pre-builds and all unit tests passing
    • At least two modules used in real world use cases on at least one VM
  • Version:
    v8.x

  • Platform:
    All

  • Subsystem:
    n-api

refack: enumerated the conditions, loosened condition 4 as I understand it. Also fixed number 4 link.

@addaleax addaleax added the node-api Issues and PRs related to the Node-API. label Jul 28, 2017
@mscdex
Copy link
Contributor

mscdex commented Jul 28, 2017

For those confused about the link to issue 4 in this repo, this issue is more relevant.

@refack
Copy link
Contributor

refack commented Jul 28, 2017

@addaleax Will you be willing to release lzma-native pre-gyped as N-API (even for just a single node version)?
@gabrielschulhof we have you down for iotivity-node (I can help with pre-gyping it)

@refack
Copy link
Contributor

refack commented Jul 28, 2017

@Silur we are looking for native-module maintainers who will release an "untagged" version built on N-API.

@addaleax
Copy link
Member

@refack You mean, my 5k downloads/month pet project? ;) Yea, sure, it’s on my list of things to do anyway, even if just to see how smooth the transition goes.

@bnoordhuis
Copy link
Member

I'll try to move over node-iconv next week. ~140k downloads/month with good continuous integration. (Its unwitting users! If anything breaks I usually hear about it within the hour.)

@mhdawson
Copy link
Member

mhdawson commented Mar 5, 2018

Request to move out of experimental for TSC review - nodejs/TSC#501

@vkurchatkin
Copy link
Contributor

Closed by #19262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

No branches or pull requests

7 participants