-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate flaky test-tls-regr-gh-5108 #10966
Comments
(Aside: This is a really good example of why I think it's good to have |
FWIW I think doing |
+1 to console.log/console.error being used (sparingly) in tests, especially console.log, as it currently is only displayed if the test fails, so it doesn't clutter up normal test output. |
If we don't want to normally see them, why not add a util.debuglog to common and use something like |
@evanlucas how would you then allow them to be seen? |
@gibfahn |
@evanlucas Cool, I didn't know about that. Definite +1 on having a Doc link: https://nodejs.org/api/util.html#util_util_debuglog_section |
To paraphrase what I wrote in #11026: So far, I haven't been able to reproduce the problem described by any of the issues listed above. In order to be able to get more information and investigate future spurious failures, I submitted a PR that sends In the meantime I'll continue trying to reproduce and investigate those issues, I'll keep you posted. |
Haven't seen this in a while. Closing. Can re-open if it recurs. |
https://ci.nodejs.org/job/node-test-commit-smartos/6523/nodes=smartos16-64/consoleFull:
The text was updated successfully, but these errors were encountered: