Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta, url: track WHATWG URL implementation in GitHub project #10625

Closed
joyeecheung opened this issue Jan 5, 2017 · 16 comments
Closed

meta, url: track WHATWG URL implementation in GitHub project #10625

joyeecheung opened this issue Jan 5, 2017 · 16 comments
Labels
meta Issues and PRs related to the general management of the project. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@joyeecheung
Copy link
Member

  • Version: all
  • Platform: all
  • Subsystem: url

The WHATWG URL spec is still moving and we are just starting to document this new API (#10620). It might be helpful to have a central place tracking the issues(especially the spec changes), doc/url/benchmark/test PRs, and it can help differentiate the WHATWG URL work from the old url module work(all under the url label at the moment) and prevent concurrent PR conflicts.

A meta issue tracking all these can be good enough but I think a GitHub project would be better. I am not very familiar with the GitHub project feature just yet but will be happy to open one if people think it's useful.

cc/ @jasnell @targos @TimothyGu

@joyeecheung joyeecheung added meta Issues and PRs related to the general management of the project. url Issues and PRs related to the legacy built-in url module. labels Jan 5, 2017
@jasnell
Copy link
Member

jasnell commented Jan 5, 2017

Go for it!

@joyeecheung
Copy link
Member Author

I've opened the project and made a few columns. Trying to move issues/PRs into it. https://github.com/nodejs/node/projects/5

Let me know if you think there is a better way to layout the columns.

@mscdex
Copy link
Contributor

mscdex commented Jan 5, 2017

What if we just add a new label and use that, like url-whatwg or something?

@joyeecheung
Copy link
Member Author

@mscdex Yes that would be very helpful too, but I think columns would make it clearer to see where we are at.

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 5, 2017

Looks like GitHub doesn't allow you to make one card out of issues + PRs :/. This makes it harder to see the progress of works to be done.

EDIT: I rearrange the columns so that PRs follow relevant issues.

@joyeecheung
Copy link
Member Author

I have added a new label whatwg-url(changed the word order from the one suggested by @mscdex , because it is how it's used in existing tests/benchmarks). If no more concerns arise I will start to label PRs/issues (not sure if the url label on them need to go?).

@mscdex
Copy link
Contributor

mscdex commented Jan 5, 2017

The reason I suggested url-whatwg in that order was that that way both labels (url and url-whatwg) will show up together in the list of labels and it might be easier for management purposes to "group" them together like this?

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 5, 2017

Most PRs use "WHATWG URL" in their names/commit logs and whatwg-url in their filenames. Could be a source of typos if the bot grabs the label from the affected subsytems section(does it?).

@mscdex
Copy link
Contributor

mscdex commented Jan 5, 2017

The nodejs github bot does not label issues, it only labels pull requests (based on files changed, base branches, etc. -- never based on any text in the original PR or commit messages).

@joyeecheung
Copy link
Member Author

OK if the bot doesn't rely on those text then it should be fine. I changed the label to url-whatwg. If it does cause typos we can always change it back I guess. Any more concerns?

@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 5, 2017
@joyeecheung
Copy link
Member Author

I've labeled the PRs and issues marked in the Github project and submitted a PR for the bot to use this new label.

@mscdex mscdex removed the url Issues and PRs related to the legacy built-in url module. label Jan 5, 2017
@addaleax
Copy link
Member

addaleax commented Jan 5, 2017

cc/ @jasnell @targos @TimothyGu

Maybe it’s a good idea to create a @nodejs/url github team with the four of you as initial members?

@targos
Copy link
Member

targos commented Jan 5, 2017

@addaleax good idea, done!

@domenic
Copy link
Contributor

domenic commented Jan 12, 2017

May I suggest a "waiting on the spec" column of some sort?

@joyeecheung
Copy link
Member Author

@domenic Seems it's done (No idea who, but thanks anyway)

@jasnell
Copy link
Member

jasnell commented Jan 12, 2017

I updated the columns last night and bit a bit of reorg/cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

No branches or pull requests

6 participants