-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta, url: track WHATWG URL implementation in GitHub project #10625
Comments
Go for it! |
I've opened the project and made a few columns. Trying to move issues/PRs into it. https://github.com/nodejs/node/projects/5 Let me know if you think there is a better way to layout the columns. |
What if we just add a new label and use that, like |
@mscdex Yes that would be very helpful too, but I think columns would make it clearer to see where we are at. |
Looks like GitHub doesn't allow you to make one card out of issues + PRs :/. This makes it harder to see the progress of works to be done. EDIT: I rearrange the columns so that PRs follow relevant issues. |
I have added a new label |
The reason I suggested |
Most PRs use "WHATWG URL" in their names/commit logs and |
The nodejs github bot does not label issues, it only labels pull requests (based on files changed, base branches, etc. -- never based on any text in the original PR or commit messages). |
OK if the bot doesn't rely on those text then it should be fine. I changed the label to |
I've labeled the PRs and issues marked in the Github project and submitted a PR for the bot to use this new label. |
Maybe it’s a good idea to create a @nodejs/url github team with the four of you as initial members? |
@addaleax good idea, done! |
May I suggest a "waiting on the spec" column of some sort? |
@domenic Seems it's done (No idea who, but thanks anyway) |
I updated the columns last night and bit a bit of reorg/cleanup. |
The WHATWG URL spec is still moving and we are just starting to document this new API (#10620). It might be helpful to have a central place tracking the issues(especially the spec changes), doc/url/benchmark/test PRs, and it can help differentiate the WHATWG URL work from the old url module work(all under the
url
label at the moment) and prevent concurrent PR conflicts.A meta issue tracking all these can be good enough but I think a GitHub project would be better. I am not very familiar with the GitHub project feature just yet but will be happy to open one if people think it's useful.
cc/ @jasnell @targos @TimothyGu
The text was updated successfully, but these errors were encountered: