Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX, FreeBSD: test-cluster-disconnect-handles intermittent failures #10609

Closed
mhdawson opened this issue Jan 4, 2017 · 11 comments
Closed

AIX, FreeBSD: test-cluster-disconnect-handles intermittent failures #10609

mhdawson opened this issue Jan 4, 2017 · 11 comments
Labels
aix Issues and PRs related to the AIX platform. cluster Issues and PRs related to the cluster subsystem. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

mhdawson commented Jan 4, 2017

  • Version: master
  • Platform: AIX
  • Subsystem: cluster

I've seen a number of failures on this test over the last little while:

https://ci.nodejs.org/job/node-test-commit-aix/2942/nodes=aix61-ppc64/console

not ok 127 parallel/test-cluster-disconnect-handles
  ---
  duration_ms: 60.107
  severity: fail
  stack: |-
    timeout
  ...
@mscdex mscdex added aix Issues and PRs related to the AIX platform. cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Jan 4, 2017
@Trott
Copy link
Member

Trott commented Jan 4, 2017

Also FreeBSD.

https://ci.nodejs.org/job/node-test-commit-freebsd/6249/nodes=freebsd10-64/console

not ok 226 parallel/test-cluster-disconnect-handles
  ---
  duration_ms: 60.78
  severity: fail
  stack: |-
    timeout

@Trott
Copy link
Member

Trott commented Jan 4, 2017

Seems like this comment in the test kinda sorta acknowledges that there is a race condition:

          // It can happen that the first continue was sent before the break
          // event was received. If that's the case, send also a continue from
          // here so the worker exits

@Trott
Copy link
Member

Trott commented Jan 4, 2017

The test uses --debug so it's going to break when we update V8 at some point in the next few months.

Not sure if the right thing to do is just get rid of the test or to rewrite it to use something else like --inspect.

/cc @nodejs/testing @nodejs/diagnostics @jkrems @s3ththompson @eugeneo

@Trott Trott added freebsd Issues and PRs related to the FreeBSD platform. debugger labels Jan 4, 2017
@Trott Trott changed the title AIX: test-cluster-disconnect-handles intermittent failures AIX, FreeBSD: test-cluster-disconnect-handles intermittent failures Jan 4, 2017
@Trott
Copy link
Member

Trott commented Jan 4, 2017

Hopefully I didn't typo any of the things in the form, but stress tests for...

AIX: https://ci.nodejs.org/job/node-stress-single-test/1097/nodes=aix61-ppc64/console

FreeBSD: https://ci.nodejs.org/job/node-stress-single-test/1098/nodes=freebsd10-64/console

@Trott
Copy link
Member

Trott commented Jan 4, 2017

Oh, maybe the failure could be due to a stuck debugger test on one of the hosts preventing usage of the TCP port. I know @thefourtheye has been trying to get the debugger tests working again, and that's involved running them in CI for the first time in a very long time. And some of them hung...

@Trott
Copy link
Member

Trott commented Jan 4, 2017

/cc @bnoordhuis who wrote the test in the first place, especially on the question of whether it makes sense to port the test to something that doesn't use the to-be-removed debug protocol or whether it makes sense to simply delete the test. (Basically: Is the debug protocol part of what's actually being tested? Doesn't seem like it to me, but ¯\(ツ)/¯ )

@Trott
Copy link
Member

Trott commented Jan 4, 2017

PR where the test landed: #3677

Maybe /cc @indutny on how to proceed as well...

@mhdawson
Copy link
Member Author

@mhdawson
Copy link
Member Author

I think this may also require cleanup after a failure as I saw it consistently fail a few times on the same machine and then there were processes hanging around on that machine. @bnoordhuis can you help out so that we can decide if we can just delete the test or if its needs to be fixed ?

@Trott
Copy link
Member

Trott commented Feb 2, 2017

Another one: https://ci.nodejs.org/job/node-test-commit-aix/3513/nodes=aix61-ppc64/console

not ok 128 parallel/test-cluster-disconnect-handles
  ---
  duration_ms: 60.101
  severity: fail
  stack: |-
    timeout

@Trott
Copy link
Member

Trott commented Jul 16, 2017

Test was moved to known_issues when _debugger was removed.

@Trott Trott closed this as completed Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. cluster Issues and PRs related to the cluster subsystem. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants