Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove removed-from-spec URL.domainToASCII/domainToUnicode #10375

Closed
domenic opened this issue Dec 21, 2016 · 2 comments
Closed

Remove removed-from-spec URL.domainToASCII/domainToUnicode #10375

domenic opened this issue Dec 21, 2016 · 2 comments
Labels
url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@domenic
Copy link
Contributor

domenic commented Dec 21, 2016

These static methods were removed from the URL Standard in whatwg/url@2bd0f59 since they were not implemented anywhere. They should have been marked experimental and at-risk in the spec, but unfortunately were not at the time, so Node implemented them. Fortunately Node's URL implementation is experimental so these should be removable without issues.

@addaleax addaleax added the url Issues and PRs related to the legacy built-in url module. label Dec 21, 2016
@jasnell
Copy link
Member

jasnell commented Dec 21, 2016

For now I would move these to hang off require('url') rather than off require('url').URL. There's value in keeping them around in Node.js given that they are so much faster than the pure javascript punycode module.

@targos
Copy link
Member

targos commented Jan 2, 2017

Moved to require('url') in abc1633.

@targos targos closed this as completed Jan 2, 2017
@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

No branches or pull requests

5 participants