From fe7ce8c92d8a1ec594cb311086d3a347ce119c34 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Tue, 8 Jan 2019 10:08:54 -0500 Subject: [PATCH] deps,v8: silence V8 self-deprecation warnings --- common.gypi | 11 ++++++----- deps/v8/gypfiles/features.gypi | 4 ++++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/common.gypi b/common.gypi index dd4f91484c9148..db857c671e0f42 100644 --- a/common.gypi +++ b/common.gypi @@ -38,19 +38,20 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.8', + 'v8_embedder_string': '-node.9', ##### V8 defaults for Node.js ##### # Old time default, now explicitly stated. 'v8_use_snapshot': 'true', + # These are more relevant for V8 internal development. # Refs: https://github.com/nodejs/node/issues/23122 # Refs: https://github.com/nodejs/node/issues/23167 - # Enable compiler warnings when using V8_DEPRECATED apis. - 'v8_deprecation_warnings': 1, - # Enable compiler warnings when using V8_DEPRECATE_SOON apis. - 'v8_imminent_deprecation_warnings': 1, + # Enable compiler warnings when using V8_DEPRECATED apis from V8 code. + 'v8_deprecation_warnings': 0, + # Enable compiler warnings when using V8_DEPRECATE_SOON apis from V8 code. + 'v8_imminent_deprecation_warnings': 0, # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, diff --git a/deps/v8/gypfiles/features.gypi b/deps/v8/gypfiles/features.gypi index 855a7a5d2f44c5..7e5af8883a8ffd 100644 --- a/deps/v8/gypfiles/features.gypi +++ b/deps/v8/gypfiles/features.gypi @@ -164,9 +164,13 @@ }], ['v8_deprecation_warnings==1', { 'defines': ['V8_DEPRECATION_WARNINGS',], + },{ + 'defines!': ['V8_DEPRECATION_WARNINGS',], }], ['v8_imminent_deprecation_warnings==1', { 'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',], + },{ + 'defines!': ['V8_IMMINENT_DEPRECATION_WARNINGS',], }], ['v8_enable_i18n_support==1', { 'defines': ['V8_INTL_SUPPORT',],