From eb6e9a0c9aa3b8d5b9a3e81d4747e33855f3d60f Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 30 May 2017 18:02:13 -0400 Subject: [PATCH] doc: remove 'you' from writing-tests.md Noticed this while reading through writing-tests.md today. As per style guide avoid the use of you, your etc. Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm PR-URL: https://github.com/nodejs/node/pull/13319 Reviewed-By: Vse Mozhet Byt Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca --- doc/guides/writing-tests.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/writing-tests.md b/doc/guides/writing-tests.md index b9e614dc256ac0..168227872c98ff 100644 --- a/doc/guides/writing-tests.md +++ b/doc/guides/writing-tests.md @@ -232,8 +232,8 @@ For performance considerations, we only use a selected subset of ES.Next features in JavaScript code in the `lib` directory. However, when writing tests, for the ease of backporting, it is encouraged to use those ES.Next features that can be used directly without a flag in [all maintained branches] -(https://github.com/nodejs/lts), you can check [node.green](http://node.green) -for all available features in each release. +(https://github.com/nodejs/lts). [node.green](http://node.green/) lists +available features in each release. For example: @@ -274,8 +274,8 @@ These imported tests will be wrapped like this: /* eslint-enable */ ``` -If you want to improve tests that have been imported this way, please send -a PR to the upstream project first. When your proposed change is merged in +To improve tests that have been imported this way, please send +a PR to the upstream project first. When the proposed change is merged in the upstream project, send another PR here to update Node.js accordingly. Be sure to update the hash in the URL following `WPT Refs:`.