From eb2d96fecf3e8a74d5a0c81ce1e5f3eed4285b02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Thu, 22 Aug 2019 23:45:49 +0200 Subject: [PATCH] module: avoid passing unnecessary loop reference It's a sync request, which doesn't require the loop parameter to be set. PR-URL: https://github.com/nodejs/node/pull/29275 Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- src/module_wrap.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/module_wrap.cc b/src/module_wrap.cc index bae5e202dcdb11..e27c644442888b 100644 --- a/src/module_wrap.cc +++ b/src/module_wrap.cc @@ -462,7 +462,7 @@ std::string ReadFile(uv_file file) { uv_buf_t buf = uv_buf_init(buffer_memory, sizeof(buffer_memory)); do { - const int r = uv_fs_read(uv_default_loop(), + const int r = uv_fs_read(nullptr, &req, file, &buf,