From e954aa0e0c5e97d2e9256e9145d13bb59ee6dfb1 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Sat, 28 Apr 2018 01:19:32 +0530 Subject: [PATCH] doc: add parameters for settings events Add parameters for the callback for the Http2Session:localSettings event and Http2Session:remoteSettings event inline with the pattern in the rest of the documentation. Refs: https://github.com/nodejs/help/issues/877#issuecomment-381253464 PR-URL: https://github.com/nodejs/node/pull/20371 Reviewed-By: Vse Mozhet Byt Reviewed-By: Trivikram Kamat Reviewed-By: Ruben Bridgewater --- doc/api/http2.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/doc/api/http2.md b/doc/api/http2.md index ea454c7134a64f..9bddf8d4330577 100644 --- a/doc/api/http2.md +++ b/doc/api/http2.md @@ -195,9 +195,10 @@ event is emitted. added: v8.4.0 --> +* `settings` {HTTP/2 Settings Object} A copy of the `SETTINGS` frame received. + The `'localSettings'` event is emitted when an acknowledgment `SETTINGS` frame -has been received. When invoked, the handler function will receive a copy of -the local settings. +has been received. When using `http2session.settings()` to submit new settings, the modified settings do not take effect until the `'localSettings'` event is emitted. @@ -215,9 +216,10 @@ session.on('localSettings', (settings) => { added: v8.4.0 --> +* `settings` {HTTP/2 Settings Object} A copy of the `SETTINGS` frame received. + The `'remoteSettings'` event is emitted when a new `SETTINGS` frame is received -from the connected peer. When invoked, the handler function will receive a copy -of the remote settings. +from the connected peer. ```js session.on('remoteSettings', (settings) => {